On 18/07/2022 21:08, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Sent: Monday, July 18, 2022 7:48 AM >> To: Shenwei Wang <shenwei.wang@xxxxxxx>; Rob Herring >> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski >> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; >> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team >> <kernel@xxxxxxxxxxxxxx>; Peng Fan <peng.fan@xxxxxxx> >> Cc: dl-linux-imx <linux-imx@xxxxxxx> >> Subject: Re: [EXT] Re: [PATCH 1/3] arm64: dts: imx: add imx8dxl support >> >> Caution: EXT Email >> >> On 15/07/2022 20:04, Shenwei Wang wrote: >>> Hi Krzysztorf >>> >>>> -----Original Message----- >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>> Sent: Thursday, July 14, 2022 6:44 AM >>>> To: Shenwei Wang <shenwei.wang@xxxxxxx>; Rob Herring >>>> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski >>>> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; >>>> Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>; Pengutronix Kernel Team >>>> <kernel@xxxxxxxxxxxxxx>; Peng Fan <peng.fan@xxxxxxx> >>>> Cc: dl-linux-imx <linux-imx@xxxxxxx> >>>> Subject: [EXT] Re: [PATCH 1/3] arm64: dts: imx: add imx8dxl support >>>> >>>> Caution: EXT Email >>>> >>>>> +<dt-bindings/firmware/imx/rsrc.h> >>>>> +#include <dt-bindings/gpio/gpio.h> >>>>> +#include <dt-bindings/interrupt-controller/arm-gic.h> >>>>> +#include <dt-bindings/input/input.h> #include >>>>> +<dt-bindings/pinctrl/pads-imx8dxl.h> >>>>> +#include <dt-bindings/thermal/thermal.h> >>>>> + >>>>> +/ { >>>>> + interrupt-parent = <&gic>; >>>>> + #address-cells = <2>; >>>>> + #size-cells = <2>; >>>>> + >>>>> + aliases { >>>>> + ethernet0 = &fec1; >>>>> + ethernet1 = &eqos; >>>>> + gpio0 = &lsio_gpio0; >>>>> + gpio1 = &lsio_gpio1; >>>>> + gpio2 = &lsio_gpio2; >>>>> + gpio3 = &lsio_gpio3; >>>>> + gpio4 = &lsio_gpio4; >>>>> + gpio5 = &lsio_gpio5; >>>>> + gpio6 = &lsio_gpio6; >>>>> + gpio7 = &lsio_gpio7;> + i2c2 = &i2c2; >>>>> + i2c3 = &i2c3; >>>> >>>> Board aliases, not SoC. >>> >>> We take these as the SoC aliases because we want to have the same alias for >> the specific IP instance independent of the board design. All the i.mx SoCs use >> the same rule. >> >> UART, most likely also I2C and SPI are board design dependent. Just because >> error was made in several other files, it is not a reason to make it again, so the >> last argument is irrelevant. >> > > The SoC alias here can give a specific IP module a uniform device file name independent of board design. It can, yet the specific alias depends on the usage of interfaces on the board, thus is board dependent. > Can you please let me know what problems are discovered with the SoC alias taking the UART as an example? Arnd explained it nicely: https://lore.kernel.org/linux-rockchip/CAK8P3a25iYksubCnQb1-e5yj=crEsK37RB9Hn4ZGZMwcVVrG7g@xxxxxxxxxxxxxx/ Best regards, Krzysztof