On Mon, Jul 18, 2022 at 07:12:47PM -0500, Bjorn Andersson wrote: > On Wed 06 Jul 17:53 CDT 2022, Christian Marangi wrote: > > > Now that these clock are defined as fixed clk in dts, we can drop the > > register_board_clk for cxo_board and pxo_board in gcc_ipq806x_probe. > > > > Are you trying to say, that now that we have .fw_name based lookup of > these clocks we don't need the globally registered [cp]xo clocks to > bridge towards the [cp]xo_board_clocks which was introduced in: > > 30fc4212d541 ("arm: dts: qcom: Add more board clocks") > > I think this change would work out if you also replace .name = "pxo" > with .name = "pxo_board_clk" (and same for cxo)... > Mhhh why pxo_board_clk? Why _clk? It should be pxo_board. Anyway about this, only the rpm clocks use pxo_board as parent, everything else use pxo. Aside from rpm and gcc the other user of pxo is the lcc driver and the krait-xcc clock. I sent patches to convert them. > > But I don't think we can just drop these, as it would break > compatibility with existing devicetree. Wonder if we will be able to drop this ever? > > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx> > > --- > > drivers/clk/qcom/gcc-ipq806x.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c > > index 718de17a1e60..883629de2751 100644 > > --- a/drivers/clk/qcom/gcc-ipq806x.c > > +++ b/drivers/clk/qcom/gcc-ipq806x.c > > @@ -3384,14 +3384,6 @@ static int gcc_ipq806x_probe(struct platform_device *pdev) > > struct regmap *regmap; > > int ret; > > > > - ret = qcom_cc_register_board_clk(dev, "cxo_board", "cxo", 25000000); > > - if (ret) > > - return ret; > > - > > - ret = qcom_cc_register_board_clk(dev, "pxo_board", "pxo", 25000000); > > - if (ret) > > - return ret; > > - > > if (of_machine_is_compatible("qcom,ipq8065")) { > > ubi32_core1_src_clk.freq_tbl = clk_tbl_nss_ipq8065; > > ubi32_core2_src_clk.freq_tbl = clk_tbl_nss_ipq8065; > > -- > > 2.36.1 > > -- Ansuel