Quoting Judy Hsiao (2022-07-18 01:02:51) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > new file mode 100644 > index 000000000000..ec8f2e555a14 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -0,0 +1,121 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * > + * This file defines the common audio settings for the child boards using rt5682 codec. Please limit this to 78 columns or so, splitting it to two lines. > + * > + * Copyright 2022 Google LLC. > + */ [...] > + > +&lpass_cpu { > + status = "okay"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&mi2s0_data0 &mi2s0_data1 &mi2s0_mclk &mi2s0_sclk &mi2s0_ws > + &mi2s1_data0 &mi2s1_sclk &mi2s1_ws>; This should be <&mi2s0_data0>, <&mi2s0_data1>, ... because the brackets are about indicating the cells the phandle takes. The phandles don't take any cells so they are closed immediately by '>'. > + > + #address-cells = <1>; > + #size-cells = <0>; > +