On 18/07/2022 11:33, Dmitry Baryshkov wrote:
On Mon, 18 Jul 2022 at 00:37, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote:Add clock-output-names as optional so that SoCs such as the msm8939 which have multiple a53 PLLs can latch the appropriate output name in drivers/clk/qcom/apcs-msm8916.c. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml index f504652fc0ea2..7497e4c930ae7 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -63,6 +63,13 @@ properties: - const: aux - const: ref + clock-output-names: + maxItems: 1 + items: + - const: a53mux_c0 + - const: a53mux_c1 + - const: a53mux_cciYou have probably meant to use enum here.
I do mean enum ... However, is there any reason
why you would like to use fixed output names here? You are going to use clocks DT properties (with clock-names or using indices) anyway, so there is no dependency on system clock name. Compare this with apcs-msm8916.c, which uses a53mux@unit_address.
The answer is because I have this in the dtsi forwarded ported from 4.19 and like an idiot I didn't check the clock names
a53pll@b016000 a53pll@b116000 a53pll@b1d0000 a53mux@b1d1000 a53mux@b011000 a53mux@b111000 you're right this is old/dead code I don't need it.
