On Mon, Sep 29, 2014 at 05:34:51PM -0700, Bjorn Andersson wrote:
> According to the datasheet for the PMIC the regulators are indeed programmed in
> steps, but the steps seems to vary between different regulators and the details
> are hidden by the RPM that exposes contiguous voltage ranges.
> Either we run with this, add a few more compatibles to encode the steps or have
> the step coming from devicetree. I prefer the current implementation as that is
> the cleanest of these.
We have support for this sort of regulator in the core anyway so just
keep on doing what you're doing.
> + if (vreg->desc.ops->set_voltage &&
> + (!initdata->constraints.min_uV || !initdata->constraints.max_uV)) {
> + dev_err(&pdev->dev, "no voltage specified for regulator\n");
> + return -EINVAL;
> + }
You shouldn't need to do this - it should be perfectly legal to have the
ability to set voltages but not use that ability.
Attachment:
signature.asc
Description: Digital signature
