Hi, On Thu, Jul 14, 2022 at 12:50 AM Jimmy Chen <jinghung.chen3@xxxxxxxxxxx> wrote: > > This adds LTE skus for villager device tree files. > > Signed-off-by: Jimmy Chen <jinghung.chen3@xxxxxxxxxxx> > > --- > > Changes in v4: > - Reorder 'status' last > > arch/arm64/boot/dts/qcom/Makefile | 3 +++ > .../boot/dts/qcom/sc7280-chrome-common.dtsi | 11 ----------- > .../arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 1 + > .../dts/qcom/sc7280-herobrine-herobrine-r1.dts | 1 + > .../boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi | 16 ++++++++++++++++ > .../qcom/sc7280-herobrine-villager-r0-lte.dts | 14 ++++++++++++++ > .../qcom/sc7280-herobrine-villager-r1-lte.dts | 14 ++++++++++++++ > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 1 + > 8 files changed, 50 insertions(+), 11 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0-lte.dts > create mode 100644 arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index bb9f4eb3e65a0..7fe7c78a79369 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -103,6 +103,9 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-r1-lte.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-crd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-herobrine-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r1.dtb As per my comments in the previous patch, the "-r1" entry should be moved from patch #3 to patch #2. Also the above line seems to be indented incorrectly. > +dtb-$(CONFIG_ARCH_QCOM) += sc7280-herobrine-villager-r0-lte.dtb For all the sc7180 Chromebook devices the "r0" variants are all sorted together. Thus the order should end up being: sc7280-herobrine-villager-r0.dtb sc7280-herobrine-villager-r0-lte.dtb sc7280-herobrine-villager-r1.dtb sc7280-herobrine-villager-r1-lte.dtb > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-lte-sku.dtsi > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Herobrine dts fragment for LTE SKUs > + * > + * Copyright 2022 Google LLC. > + */ > +/* Modem setup is different on Chrome setups than typical Qualcomm setup */ > + > +&remoteproc_mpss { > + compatible = "qcom,sc7280-mss-pil"; > + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; You accidentally dropped the "interconnects" property that was added by commit a0cdc83fa89b ("arm64: dts: qcom: sc7280: Add proxy interconnect requirements for modem"). Please put it back.