On 14.07.2022 13:41, Krzysztof Kozlowski wrote: > On 14/07/2022 12:12, Sergiu Moga wrote: >> Convert at91sam9 WDT binding for Atmel/Microchip SoCs to Device Tree >> Schema format. I somehow wrote "Device Tree Schema" here instead of "json-schema". Will correct the commit message in the next version. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> >> --- >> .../bindings/watchdog/atmel,at91sam9-wdt.yaml | 127 ++++++++++++++++++ >> .../bindings/watchdog/atmel-wdt.txt | 51 ------- >> 2 files changed, 127 insertions(+), 51 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/watchdog/atmel,at91sam9-wdt.yaml >> delete mode 100644 Documentation/devicetree/bindings/watchdog/atmel-wdt.txt >> >> diff --git a/Documentation/devicetree/bindings/watchdog/atmel,at91sam9-wdt.yaml b/Documentation/devicetree/bindings/watchdog/atmel,at91sam9-wdt.yaml >> new file mode 100644 >> index 000000000000..b3f7cbe913a5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/watchdog/atmel,at91sam9-wdt.yaml >> @@ -0,0 +1,127 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/watchdog/atmel,at91sam9-wdt.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel Watchdog Timers >> + >> +maintainers: >> + - Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx> >> + >> +allOf: >> + - $ref: watchdog.yaml# >> + - if: >> + properties: >> + atmel,reset-type: >> + enum: >> + - all >> + - proc >> + then: >> + properties: >> + atmel,watchdog-type: >> + const: hardware > Entire allOf in such case goes after "required:". Noted. Thank you. > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof