On 14/07/2022 12:07, Johan Hovold wrote: > On Thu, Jul 14, 2022 at 11:21:52AM +0200, Krzysztof Kozlowski wrote: >> On 07/07/2022 15:47, Johan Hovold wrote: >>> Add the missing "qref" clock used by the SM8450 UFS QMP PHY to the >>> binding. >>> >>> Fixes: e04121ba1b08 ("dt-bindings: phy: qcom,qmp: Add SM8450 UFS phy compatible") >>> Fixes: 07fa917a335e ("arm64: dts: qcom: sm8450: add ufs nodes") >> >> The second fixes seems not appropriate here, because you are not fixing >> a DTS. A fix for DTS would be a fix for that one. > > I wanted to highlight the fact the binding wasn't amended when the DTS > started using the new clock, which it should have. But sure, that would > have gone in a separate patch. I can replace the second Fixes with a > Link to the dts submission as a reference instead. Yes, that or mentioning as "commit xxx ..." in msg would be better. Best regards, Krzysztof