Re: [PATCH 3/6] ARM: dts: qcom: msm8974: Disable remoteprocs by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/07/2022 14:44, Stephan Gerhold wrote:
> The remoteproc configuration in qcom-msm8974.dtsi is incomplete because
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 814ad0b46232..35246bd02132 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1172,6 +1172,8 @@ remoteproc_mss: remoteproc@fc880000 {
>  			qcom,smem-states = <&modem_smp2p_out 0>;
>  			qcom,smem-state-names = "stop";
>  
> +			status = "disabled";
> +
>  			mba {
>  				memory-region = <&mba_region>;
>  			};
> @@ -1639,6 +1641,8 @@ remoteproc_adsp: remoteproc@fe200000 {
>  			qcom,smem-states = <&adsp_smp2p_out 0>;
>  			qcom,smem-state-names = "stop";
>  
> +			status = "disabled";
> +
>  			smd-edge {
>  				interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>;
>  
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> index 58cb2ce1e4df..8a6b8e4de887 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-fairphone-fp2.dts
> @@ -147,10 +147,12 @@ wcnss {
>  };
>  
>  &remoteproc_adsp {
> +	status = "okay";

These go to the end of properties.

>  	cx-supply = <&pm8841_s2>;
>  };
>  
>  &remoteproc_mss {
> +	status = "okay";

Ditto

>  	cx-supply = <&pm8841_s2>;
>  	mss-supply = <&pm8841_s3>;
>  	mx-supply = <&pm8841_s1>;
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> index d6b2300a8223..577cbffad010 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-samsung-klte.dts
> @@ -457,10 +457,12 @@ fuelgauge_pin: fuelgauge-int-pin {
>  };
>  
>  &remoteproc_adsp {
> +	status = "okay";

Ditto

>  	cx-supply = <&pma8084_s2>;
>  };
>  
>  &remoteproc_mss {
> +	status = "okay";
>  	cx-supply = <&pma8084_s2>;
>  	mss-supply = <&pma8084_s6>;
>  	mx-supply = <&pma8084_s1>;


Best regards,
Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux