On 13/07/2022 06:53, Dongjin Yang wrote: > Add an devicetree bindings for Samsung secure monitor call service. > This driver is used for SoCs produced by Samsung Foundry to provide > SMC call. This patch supports register read/write request to secure > monitor. Also, SMC call request which uses shared memory to exchange > the data between kernel and secure monitor. > > Signed-off-by: Dongjin Yang <dj76.yang@xxxxxxxxxxx> > --- > .../bindings/firmware/samsung,smccc-svc.yaml | 31 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 32 insertions(+) > create mode 100644 Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml > > diff --git a/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml > new file mode 100644 > index 000000000000..427c42a6cd75 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml > @@ -0,0 +1,31 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/samsung,smccc-svc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung Secure Monitor call service > + > +maintainers: > + - Jesper Nilsson <jesper.nilsson@xxxxxxxx> > + > +description: | > + The file documents device tree bindings of Samsung secure monitor > + call service. > + > +properties: > + compatible: Please add SoC comaptible followed by generic samsung,smccc-svc (so you need items with an enum and const). > + const: samsung,smccc-svc > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + No need for blank line. > + samsung-svc { Generic node names, e.g. smc. > + compatible = "samsung,smccc-svc"; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 20133dcd8ce9..6763746c349f 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1862,6 +1862,7 @@ M: Jesper Nilsson <jesper.nilsson@xxxxxxxx> > M: Lars Persson <lars.persson@xxxxxxxx> > L: linux-arm-kernel@xxxxxxxx > S: Maintained > +F: Documentation/devicetree/bindings/firmware/samsung,smccc-svc.yaml Does not look related to Artpec. Shouldn't this be under Samsung Exynos? > F: Documentation/devicetree/bindings/pinctrl/axis,artpec6-pinctrl.txt > F: arch/arm/boot/dts/artpec6* > F: arch/arm/mach-artpec Best regards, Krzysztof