On 13/07/2022 08:48, Tommaso Merciai wrote: > Hi Rob, > > On Tue, Jul 12, 2022 at 04:29:35PM -0600, Rob Herring wrote: >> On Tue, 12 Jul 2022 18:33:48 +0200, Tommaso Merciai wrote: >>> Add documentation of device tree in YAML schema for the OV5693 >>> CMOS image sensor from Omnivision >>> >>> Signed-off-by: Tommaso Merciai <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> --- >>> Changes since v1: >>> - Fix allOf position as suggested by Krzysztof >>> - Remove port description as suggested by Krzysztof >>> - Fix EOF as suggested by Krzysztof >>> >>> Changes since v2: >>> - Fix commit body as suggested by Krzysztof >>> >>> Changes since v3: >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof >>> >>> Changes since v4: >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari >>> >>> Changes since v5: >>> - Remove dovdd-supply, avdd-supply, dvdd-supply from required properties >>> as suggested by Jacopo >>> >>> .../bindings/media/i2c/ovti,ov5693.yaml | 103 ++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 104 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb: camera@36: Unevaluated properties are not allowed ('port' was unexpected) >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/patch/ >> >> This check can fail if there are any dependencies. The base for a patch >> series is generally the most recent rc1. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: >> >> pip3 install dtschema --upgrade >> >> Please check and re-submit. >> > > I run: > > pip3 install dtschema --upgrade > > Then I check .yaml using: > > make DT_CHECKER_FLAGS=-m dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > DTEX Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dts > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > CHECK Documentation/devicetree/bindings/media/i2c/ovti,ov5693.example.dtb > > No error on my side. I'm missing something? Rob's check are running newer dtschema, from master branch. The error he reports is about missing port, although I thought it is coming from video-interface-devices. Best regards, Krzysztof