On Thu, 2022-07-07 at 10:21 +0800, CK Hu wrote:
> Hi, Bo-Chen:
>
> On Fri, 2022-07-01 at 14:28 +0800, Bo-Chen Chen wrote:
> > From: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> >
> > This patch adds a embedded displayport driver for the MediaTek
> > mt8195
> > SoC.
> >
> > It supports the MT8195, the embedded DisplayPort units. It offers
> > DisplayPort 1.4 with up to 4 lanes.
> >
> > The driver creates a child device for the phy. The child device
> > will
> > never exist without the parent being active. As they are sharing a
> > register range, the parent passes a regmap pointer to the child so
> > that
> > both can work with the same register range. The phy driver sets
> > device
> > data that is read by the parent to get the phy device that can be
> > used
> > to control the phy properties.
> >
> > This driver is based on an initial version by
> > Jitao shi <jitao.shi@xxxxxxxxxxxx>
> >
> > Signed-off-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>
> > Signed-off-by: Guillaume Ranquet <granquet@xxxxxxxxxxxx>
> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx>
> > ---
> > +
> > +static void mtk_dp_power_disable(struct mtk_dp *mtk_dp)
> > +{
> > + mtk_dp_write(mtk_dp, MTK_DP_TOP_PWR_STATE, 0);
> > +
> > + mtk_dp_write(mtk_dp, MTK_DP_0034,
> > + DA_CKM_CKTX0_EN_FORCE_EN |
> > + DA_CKM_BIAS_LPF_EN_FORCE_VAL |
> > + DA_CKM_BIAS_EN_FORCE_VAL |
> > + DA_XTP_GLB_LDO_EN_FORCE_VAL |
> > + DA_XTP_GLB_AVD10_ON_FORCE_VAL);
>
> clk-mt8195-vdo0 driver [1] is part of mtk-mmsys driver [2] and it is
> still separated out to ccf driver. In addition, you does not manage
> the
> parent clock. If the parent clock is not enable, these leaf clock
> would
> not work.
>
> [1]
>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clk/mediatek/clk-mt8195-vdo0.c?h=v5.19-rc5#n138
>
> [2]
>
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/soc/mediatek/mtk-mmsys.c?h=v5.19-rc5#n140
>
> Regards,
> CK
>
Hello CK,
MTK_DP_0034 is just a enable control for dp hardware, so I think we
don't need to move it to ccf driver. it's not related to ccf.
After checking with Jitao, we only need to update
DA_CKM_CKTX0_EN_FORCE_E. I will set this bit as 1 in
mtk_dp_power_disable and 0 in mtk_dp_power_enable
BRs,
Bo-Chen
> > +
> > + /* Disable RX */
> > + mtk_dp_write(mtk_dp, MTK_DP_1040, 0);
> > + mtk_dp_write(mtk_dp, MTK_DP_TOP_MEM_PD,
> > + 0x550 | BIT(FUSE_SEL_SHIFT) |
> > BIT(MEM_ISO_EN_SHIFT));
> > +}
> > +
>
>
