On 12/07/2022 04:11, William Zhang wrote: > Merge BCM4908 SoC device tree description into BCMBCA and combined > all BCM4908 chip variants into the same BCM4908 chip family item. Merge means you combine some entries, so I would expect to see the removal here as well. > > Each compatible string represent the whole chip family. The board > variants and chip varints go into the first and second enum in the > compatible string item list. > > Signed-off-by: William Zhang <william.zhang@xxxxxxxxxxxx> > --- > > .../bindings/arm/bcm/brcm,bcmbca.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > index d9dc4f22f4a5..906c3e1de372 100644 > --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcmbca.yaml > @@ -28,6 +28,23 @@ properties: > - const: brcm,bcm47622 > - const: brcm,bcmbca > > + - description: BCM4908 Family based boards > + items: > + - enum: > + # BCM4908 SoC based boards > + - brcm,bcm94908 > + - asus,gt-ac5300 > + - netgear,raxe500 > + # BCM4906 SoC based boards > + - brcm,bcm94906 > + - netgear,r8000p > + - tplink,archer-c2300-v1 > + - enum: > + - brcm,bcm4908 > + - brcm,bcm4906 > + - brcm,bcm49408 This is wrong. brcm,bcm94908 followed by brcm,bcm4906 does not look like valid list of compatibles. > + - const: brcm,bcmbca > + > - description: BCM4912 based boards > items: > - enum: Best regards, Krzysztof
