On Thu, Jul 07, 2022 at 05:33:58PM +0300, Georgi Djakov wrote: [...] > > @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > > provider = src->provider; > > qp = to_qcom_provider(provider); > > - list_for_each_entry(n, &provider->nodes, node_list) > > - provider->aggregate(n, 0, n->avg_bw, n->peak_bw, > > - &agg_avg, &agg_peak); > > + qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg, > > + &max_agg_peak); > > - sum_bw = icc_units_to_bps(agg_avg); > > - max_peak_bw = icc_units_to_bps(agg_peak); > > + sum_bw = icc_units_to_bps(max_agg_avg); > > + max_peak_bw = icc_units_to_bps(max_agg_peak); > > ret = __qcom_icc_set(src, src_qn, sum_bw); > > if (ret) > > @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > > return ret; > > } > > - rate = max(sum_bw, max_peak_bw); > > Looks like max_peak_bw is unused now? Yes, will drop it in next spin. Thanks for review. Leo