On Thu, Jul 07, 2022 at 05:24:44PM +0530, Sumit Garg wrote:
> This was a difficult inconsistency to be caught as both the USB PHYs were
> being enabled in the kernel and USB worked fine. But when I was trying to
> enable USB support in u-boot with all the required drivers ported, I
> couldn't get the same USB storage device enumerated in u-boot which was
> being enumerated fine by the kernel.
This is not really a description of the change. It is more like a
narrative about how you discovered and tested the problem (making it
hard work to read). If I understand correctly the current DT has the
PHYs setup backwards. This works but only by luck: as each USB HCI
comes up it configures the *other* controllers PHY which is enough
to make them happy. If, for any reason, we were disable one of the
controllers then both would stop working.
Perhaps kick off this description using something like the following
pattern[1].
Current code does (A), this has a problem when (B).
We can improve this doing (C), because (D).
I think everything in the paragraph above belongs in (D) (e.g. how you
know your patch is correct).
Daniel.
[1] For the record, I didn't write this formulation... I stole it:
https://lore.kernel.org/all/20131111113218.GF15810@xxxxxxxxx/
