Re: [PATCH 2/6] arm64: dts: qcom: sc7280: use constants for gpucc clocks and power-domains

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 06 Jul 10:43 CDT 2022, Krzysztof Kozlowski wrote:

> On 06/07/2022 16:54, Dmitry Baryshkov wrote:
> > To ease merging of bindings and dts files, the constants were replaced
> 
> In the future I recommend just adding defines in top part of DTSI (under
> ifdef not defined). Then when time comes, you drop this entire piece of
> defines which makes it extra readable and easy to review. Nice clean
> patchset.
> 

I worked out the underlying issue with the clock maintainer, so we
should just use the dt-bindings defines directly from the beginning.

Regards,
Bjorn

> To review this approach, I would need to check every define if it
> matches the previous number.
> 
> Best regards,
> Krzysztof



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux