On Wed, Jul 06, 2022 at 05:10:50PM +0100, Will Deacon wrote: > On Wed, Jul 06, 2022 at 05:50:14PM +0200, Greg Kroah-Hartman wrote: > > On Wed, Jul 06, 2022 at 04:21:01PM +0100, Will Deacon wrote: > > > > +MODULE_LICENSE("GPL"); > > > > > > This needs to be "GPL v2". > > > > Nope, that is what this is saying, please see the huge comment in > > include/linux/module.h right above MODULE_LICENSE(). So all is good > > here. > > Thanks, I stand corrected, although I personally still find it clearer to > spell it out! I totally agree, but there is no "you must do this" directive here :)