On Mon, 2022-07-04 at 14:36 +0200, Krzysztof Kozlowski wrote: > On 04/07/2022 12:00, Tinghan Shen wrote: > > The max clock items for the dts node with compatible > > 'mediatek,mt8195-smi-sub-common' should be 3. > > > > However, the dtbs_check of such node will get following message, > > arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] > > is too long > > From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi- > > common.yaml > > > > Remove the last 'else' checking to fix this error. > > Missing fixes tag. > > > > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> > > --- > > .../memory-controllers/mediatek,smi-common.yaml | 10 +++++++++- > > 1 file changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > index a98b359bf909..e5f553e2e12a 100644 > > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > @@ -143,7 +143,15 @@ allOf: > > - const: gals0 > > - const: gals1 > > > > - else: # for gen2 HW that don't have gals > > + - if: # for gen2 HW that don't have gals > > + properties: > > + compatible: > > + enum: > > + - mediatek,mt2712-smi-common > > + - mediatek,mt8167-smi-common > > + - mediatek,mt8173-smi-common > > + > > Without looking at the code, it's impossible to understand what you are > doing here. The commit msg says one, but you are doing something else. > > Write commit msg explaining what you want to achieve and what you are doing. > > > Best regards, > Krzysztof Ok, I'll update in next version. Thanks, TingHan
