Hi Krzysztof Kozlowski, thanks for your comment, I'll change it in the next serial. Thanks, Xin On Tue, Jul 05, 2022 at 04:27:28PM +0200, Krzysztof Kozlowski wrote: > On 05/07/2022 07:36, Xin Ji wrote: > > Add analogix PD chip anx7411 device binding > > > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx> > > > > --- > > v12 -> v13 : > > 1. Drop the quotes for "$id" and "$schema" > > 2. Remove "allOf" label > > 3. Change node name from "i2c1" to "i2c" > > 4. Change node name from "typec" to "usb-typec" > > --- > > .../bindings/usb/analogix,anx7411.yaml | 76 +++++++++++++++++++ > > 1 file changed, 76 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > new file mode 100644 > > index 000000000000..57429864d499 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml > > @@ -0,0 +1,76 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fanalogix%2Canx7411.yaml%23&data=05%7C01%7Cxji%40analogixsemi.com%7Cbb10f7b74a6d4924d7a108da5e928029%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637926280579332615%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JfpqaGXa6TUI7iOzxcxOuSaQaMHdoWxqH1fTJCuHi%2Fs%3D&reserved=0 > > +$schema: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cxji%40analogixsemi.com%7Cbb10f7b74a6d4924d7a108da5e928029%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637926280579332615%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oK3lhKtiDat%2Bm1u7%2BacAImLuxsQ%2BkYTV9TCtZAweK2A%3D&reserved=0 > > + > > +title: Analogix ANX7411 Type-C controller bindings > > + > > +maintainers: > > + - Xin Ji <xji@xxxxxxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - analogix,anx7411 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + connector: > > + type: object > > + $ref: ../connector/usb-connector.yaml > > + description: > > + Properties for usb c connector. > > + > > + properties: > > + compatible: > > + const: usb-c-connector > > + > > + power-role: true > > + > > + data-role: true > > + > > + try-power-role: true > > + > > + required: > > + - compatible > > + > > +required: > > + - compatible > > + - reg > > + - connector > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + usb-typec: anx7411@2C { > > 1. node name is still not correct. > 2. lowercase hex, so @2c. OK > > > + compatible = "analogix,anx7411"; > > + reg = <0x2C>; > > lowercase hex OK > > > + interrupts = <8 IRQ_TYPE_EDGE_FALLING>; > > + interrupt-parent = <&gpio0>; > > + > > + typec_con: connector { > > + compatible = "usb-c-connector"; > > + power-role = "dual"; > > + data-role = "dual"; > > + try-power-role = "source"; > > The DT schema requires ports property and just "port" is not accepted. OK > > > + > > + port { > > + typec_con_ep: endpoint { > > + remote-endpoint = <&usbotg_hs_ep>; > > + }; > > + }; > > + }; > > + }; > > + }; > > +... > > > Best regards, > Krzysztof