On 05/07/2022 17:59, Pali Rohár wrote: > Add device-tree bindings documentation for Turris 1.x RGB LEDs. The patchset is difficult to find because you attached it to some older thread. Don't. > > Signed-off-by: Pali Rohár <pali@xxxxxxxxxx> > > --- > Changes in v2: > * Fix schema errors > --- > .../bindings/leds/cznic,turris1x-leds.yaml | 118 ++++++++++++++++++ > 1 file changed, 118 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > new file mode 100644 > index 000000000000..bcaab5b03128 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/cznic,turris1x-leds.yaml > @@ -0,0 +1,118 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/cznic,turris1x-leds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: CZ.NIC's Turris 1.x LEDs driver > + > +maintainers: > + - Pali Rohár <pali@xxxxxxxxxx> > + > +description: > + This module adds support for the RGB LEDs found on the front panel of the > + Turris 1.x routers. There are 8 RGB LEDs that are controlled by CZ.NIC CPLD > + firmware running on Lattice FPGA. Firmware is open source and available at > + https://gitlab.nic.cz/turris/hw/turris_cpld/-/blob/master/CZ_NIC_Router_CPLD.v > + > +properties: > + compatible: > + const: cznic,turris1x-leds > + > + reg: > + description: CPLD address range where LED registers are mapped > + maxItems: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +patternProperties: > + "^multi-led@[0-7]$": > + type: object > + $ref: leds-class-multicolor.yaml# > + unevaluatedProperties: false > + > + properties: > + reg: > + minimum: 0 > + maximum: 7 > + > + required: > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/leds/common.h> > + > + cpld@3,0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x3 0x0 0x00020000>; > + > + led-controller@13 { > + compatible = "cznic,turris1x-leds"; > + reg = <0x13 0x1d>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + multi-led@0 { > + reg = <0x0>; You have some weird indentation here. In other places of DTS example it is correct four spaces, so here should be four spaces as well. Best regards, Krzysztof
