On 05/07/2022 14:00, Kavyasree.Kotagiri@xxxxxxxxxxxxx wrote: >>> Convert the Atmel flexcom device tree bindings to json schema. >>> >>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>> --- >>> v5 -> v6: >>> - Removed spi node from example as suggested by Rob and >>> also pattern properties(spi dt-bindings conversion to yaml patch is under >> review). >>> Once that is accepted, I will add back spi example through new patch. >>> >>> v4 -> v5: >>> - Fixed indentations. >>> >>> v3 -> v4: >>> - Corrected format of enum used for compatible string. >>> >>> v2 -> v3: >>> - used enum for compatible string. >>> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. >>> - fixed dtschema errors. >>> >>> v1 -> v2: >>> - Fix title. >>> >>> .../bindings/mfd/atmel,flexcom.yaml | 72 +++++++++++++++++++ >>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ---------------- >>> 2 files changed, 72 insertions(+), 63 deletions(-) >>> create mode 100644 >> Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml >> >> AFAICT it would be better to have it named atmel,sama5d2-flexcom.yaml. >> > I see most of the yaml filenames have format of "vendor, function.yaml".For example: Documentation/devicetree/bindings/spi/atmel,quadspi.yaml > So, I think it is ok to use "atmel,flexcom.yaml". Most files not correct. The recommended naming is based on first compatible, so as Claudiu suggested. Best regards, Krzysztof
