On 27/06/2022 10:17, Krzysztof Kozlowski wrote: > On 16/06/2022 02:52, Krzysztof Kozlowski wrote: >> The gpio-keys DT schema matches all properties with a wide pattern and >> applies specific schema to children. This has drawback - all regular >> properties are also matched and are silently ignored, even if they are >> not described in schema. Basically this allows any non-object property >> to be present. >> >> Enforce specific naming pattern for children (keys) to narrow the >> pattern thus do not match other properties. This will require all >> children to be properly prefixed or suffixed (button, event, switch or >> key). >> >> Removal of "if:" within patternProperties causes drop of one indentation >> level, but there are no other changes in the affected block. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> --- >> .../devicetree/bindings/input/gpio-keys.yaml | 157 +++++++++--------- >> 1 file changed, 77 insertions(+), 80 deletions(-) >> > > Dmitry, > > Any comments from your side? Are you planning to pick up the dt-bindings > here (patch 1-3)? Hmmm, I guess this should go via dt-bindings then... Best regards, Krzysztof
