On 05/07/2022 11:42, Johan Hovold wrote: > The QMP PHY DT schema is getting unwieldy. Break out the PCIe PHY > binding in a separate file. > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > .../bindings/phy/qcom,qmp-pcie-phy.yaml | 188 ++++++++++++++++++ > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 75 ------- > 2 files changed, 188 insertions(+), 75 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml > new file mode 100644 > index 000000000000..d1d4a468acc3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-pcie-phy.yaml > @@ -0,0 +1,188 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + No new line. > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/qcom,qmp-pcie-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" Drop quotes. > + > +title: Qualcomm QMP PHY controller (PCIe) > + > +maintainers: > + - Vinod Koul <vkoul@xxxxxxxxxx> > + > +description: > + QMP PHY controller supports physical layer functionality for a number of > + controllers on Qualcomm chipsets, such as, PCIe, UFS, and USB. > + > +properties: > + compatible: > + enum: > + - qcom,ipq6018-qmp-pcie-phy > + - qcom,ipq8074-qmp-pcie-phy > + - qcom,msm8998-qmp-pcie-phy > + - qcom,sc8180x-qmp-pcie-phy > + - qcom,sdm845-qhp-pcie-phy > + - qcom,sdm845-qmp-pcie-phy > + - qcom,sdx55-qmp-pcie-phy > + - qcom,sm8250-qmp-gen3x1-pcie-phy > + - qcom,sm8250-qmp-gen3x2-pcie-phy > + - qcom,sm8250-qmp-modem-pcie-phy > + - qcom,sm8450-qmp-gen3x1-pcie-phy > + - qcom,sm8450-qmp-gen4x2-pcie-phy > + > + reg: > + minItems: 1 > + items: > + - description: Address and length of PHY's common serdes block. > + - description: Address and length of PHY's DP_COM control block. All my msm8996-qmp-pcie comments apply. Best regards, Krzysztof