> > > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx> > > > > --- > > > > v3 -> v4: > > > > - Corrected format of enum used for compatible string. > > > > > > > > v2 -> v3: > > > > - used enum for compatible string. > > > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > > > - fixed dtschema errors. > > > > > > > > v1 -> v2: > > > > - Fix title. > > > > > > > > .../bindings/mfd/atmel,flexcom.yaml | 104 ++++++++++++++++++ > > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------- > > > > 2 files changed, 104 insertions(+), 63 deletions(-) > > > > create mode 100644 > > > Documentation/devicetree/bindings/mfd/atmel,flexcom.yaml > > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > > flexcom.txt > > > > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > > following warnings. Consider if they are expected or the schema is > > > incorrect. These may not be new warnings. > > > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > > This will change in the future. > > > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > > > > flexcom@f0000000: spi@400:compatible:0: 'atmel,at91rm9200-spi' was > > > expected > > > arch/arm/boot/dts/at91-sam9x60ek.dtb > > > > > > flexcom@f0000000: spi@400:compatible: ['microchip,sam9x60-spi', > > > 'atmel,at91rm9200-spi'] is too long > > > arch/arm/boot/dts/at91-sam9x60ek.dtb > > > > These errors are expected because "microchip,sam9x60-spi" and > "atmel,at91rm9200-spi" > > are documented in Documentation/devicetree/bindings/spi/spi_atmel.txt. > > which I added in description as > > " description: See ../spi/spi_atmel.txt for details of SPI bindings." > > If that was still true, there would not be a warning because .txt files > don't cause warnings. You've defined the SPI compatible here and that > doesn't agree with the dts files. One of them is wrong. > > Normally, child nodes either just reference another schema or document > everything locally. You've done a mixture which is not right. Presumably > that was to avoid 'undocumented compatible' warnings. To fix that you > either need to convert the SPI binding or don't use it in the example. > For now, I will remove the spi node from example and send my v6 patch series. I will add it back once below patch is accepted: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@xxxxxxxxxxxxx/ Please let me know your comments. > Rob
