Re: [PATCH v12 2/3] dt-bindings: usb: Add analogix anx7411 PD binding

[Xin Ji <xji@xxxxxxxxxxxxxxxx>]

Hi Krzysztof Kozlowski, thanks for comment, I'll fix it in the next
serial.

Thanks,
Xin


On Wed, Jun 29, 2022 at 12:12:29PM +0200, Krzysztof Kozlowski wrote:
> On 28/06/2022 06:48, Xin Ji wrote:
> > Add analogix PD chip anx7411 device binding
> > 
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > ---
> >  .../bindings/usb/analogix,anx7411.yaml        | 76 +++++++++++++++++++
> >  1 file changed, 76 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > new file mode 100644
> > index 000000000000..c5c6d5a9dc17
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: "https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fanalogix%2Canx7411.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C3da117aa187343f9f18908da59b7e50c%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637920943621030352%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=RiPhqeKC%2FZjJYcybauOd47OgSmEXtqxoz%2BPc8nwcbAo%3D&amp;reserved=0";
> > +$schema: "https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C3da117aa187343f9f18908da59b7e50c%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637920943621030352%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=uCZMyAOdxsFcpDyn8c6WBwrs0Zraw3hloFZw6SjzXTA%3D&amp;reserved=0";
> 
> Drop the quotes from both places.
OK
> 
> > +
> > +title: Analogix ANX7411 Type-C controller bindings
> > +
> > +maintainers:
> > +  - Xin Ji <xji@xxxxxxxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - analogix,anx7411
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  connector:
> > +    type: object
> > +
> > +    allOf:
> > +      - $ref: ../connector/usb-connector.yaml
> 
> additionalProperties: false
> (on the level of allOf)
OK
> 
> > +
> > +    properties:
> > +      compatible:
> > +        const: usb-c-connector
> > +
> > +      power-role: true
> > +
> > +      data-role: true
> > +
> > +      try-power-role: true
> > +
> > +    required:
> > +      - compatible
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - connector
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c1 {
> 
> "i2c"
OK
> 
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        typec: anx7411@2C {
> 
> generic node name, so maybe usb-typec?
> 
> If fixed, keep Rob's Rb comment.
OK
> 
> > +            compatible = "analogix,anx7411";
> > +            reg = <0x2C>;
> > +            interrupts = <8 IRQ_TYPE_EDGE_FALLING>;
> > +            interrupt-parent = <&gpio0>;
> > +
> > +            typec_con: connector {
> > +                compatible = "usb-c-connector";
> > +                power-role = "dual";
> > +                data-role = "dual";
> > +                try-power-role = "source";
> > +
> > +                port {
> 
> I think usb-c-connector requires "ports" node, doesn't it?
Not sure, I just follow the example, as the driver code test OK, I'll
keep this define
> 
> > +                    typec_con_ep: endpoint {
> > +                        remote-endpoint = <&usbotg_hs_ep>;
> > +                    };
> > +                };
> > +            };
> > +        };
> > +    };
> > +...
> 
> 
> Best regards,
> Krzysztof