On 04/07/2022 08:07, Claudiu Beznea - M18063 wrote: > On 02.07.2022 18:34, Conor Dooley - M52691 wrote: >> On 01/07/2022 08:55, Conor Dooley wrote: >>> On 01/07/2022 08:47, Claudiu Beznea - M18063 wrote: >>>> On 01.07.2022 09:58, Conor Dooley wrote: >>>>> To date, the Microchip PolarFire SoC (MPFS) has been using the >>>>> cdns,macb compatible, however the generic device does not have reset >>>>> support. Add a new compatible & .data for MPFS to hook into the reset >>>>> functionality added for zynqmp support (and make the zynqmp init >>>>> function generic in the process). >>>>> >>>>> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >>>>> --- >>>>> drivers/net/ethernet/cadence/macb_main.c | 25 +++++++++++++++++------- >>>>> 1 file changed, 18 insertions(+), 7 deletions(-) >>>>> >>>>> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c >>>>> index d89098f4ede8..325f0463fd42 100644 >>>>> --- a/drivers/net/ethernet/cadence/macb_main.c >>>>> +++ b/drivers/net/ethernet/cadence/macb_main.c >>>>> @@ -4689,33 +4689,32 @@ static const struct macb_config np4_config = { >>>>> .usrio = &macb_default_usrio, >>>>> }; >>>>> -static int zynqmp_init(struct platform_device *pdev) >> >> I noticed that this function is oddly placed within the macb_config >> structs definitions. Since I am already modifying it, would you like >> me to move it above them to where the fu540 init functions are? > > That would be good, thanks! Cool, I'll respin with extra patches for the cleanup. Thanks for the review Claudiu :)