On Thu, Jun 30, 2022 at 05:33:09PM +0200, AngeloGioacchino Del Regno wrote:
> Add the regulators layout for this platform, including the basic power
> rails controlled by the EC (and/or always on).
> Moreover, include the MT6359 PMIC devicetree and add some configuration
> for its regulators, essential to keep the machine alive after booting.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../boot/dts/mediatek/mt8195-cherry.dtsi | 102 ++++++++++++++++++
> 1 file changed, 102 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index 14f8f30b1eb3..091338f7d5ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include "mt8195.dtsi"
> +#include "mt6359.dtsi"
>
> / {
> aliases {
> @@ -19,6 +20,107 @@ memory@40000000 {
> device_type = "memory";
> reg = <0 0x40000000 0 0x80000000>;
> };
> +
> + /* system wide LDO 3.3V power rail */
> + pp3300_z5: regulator-3v3-pp3300-ldo-z5 {
I wouldn't have both "3v3" and "pp3300" in the node name since they mean the
same thing, but feel free to ignore this comment :).
> + compatible = "regulator-fixed";
> + regulator-name = "pp3300_ldo_z5";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&ppvar_sys>;
> + };
> +
> + /* separately switched 3.3V power rail */
> + pp3300_s3: regulator-3v3-pp3300-s3 {
> + compatible = "regulator-fixed";
> + regulator-name = "pp3300_s3";
> + /* automatically sequenced by PMIC EXT_PMIC_EN2 */
> + regulator-always-on;
> + regulator-boot-on;
Missing regulator-min/max-microvolt?
> + vin-supply = <&pp3300_z2>;
> + };
[..]
> --
> 2.35.1
>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
Thanks,
Nícolas
