Re: [PATCH 5/7] dt-bindings: msm: dsi: Fix clock declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 30 June 2022 15:08:43 GMT+03:00, Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> wrote:
>When converting from .txt to .yaml dt-binding descriptions we appear to
>have missed some of the previous detail on the number and names of
>permissible clocks.
>
>Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
>Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
>---
> .../display/msm/dsi-controller-main.yaml      | 23 +++++++++++++------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>index fd9d472437853..b24ba6c346a77 100644
>--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>@@ -28,22 +28,31 @@ properties:
>     maxItems: 1
> 
>   clocks:
>-    items:
>-      - description: Display byte clock
>-      - description: Display byte interface clock
>-      - description: Display pixel clock
>-      - description: Display escape clock
>-      - description: Display AHB clock
>-      - description: Display AXI clock
>+    minItems: 6
>+    maxItems: 9

Please leave descriptions here. They are better suited for the clocks rather than clock-names.

With that fixed:

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

> 
>   clock-names:
>     items:
>       - const: byte
>+        description: Display byte clock
>       - const: byte_intf
>+        description: Display byte interface clock
>       - const: pixel
>+        description: Display pixel clock
>       - const: core
>+        description: Display escape clock
>       - const: iface
>+        description: Display AHB clock
>       - const: bus
>+        description: Display AXI clock
>+      - const: core_mmss
>+        description: Core MultiMedia SubSystem clock
>+      - const: mdp_core
>+        description: MDP Core clock
>+      - const: mnoc
>+        description: MNOC clock
>+    minItems: 6
>+    maxItems: 9
> 
>   phys:
>     maxItems: 1

-- 
With best wishes
Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux