On Mon, Sep 29, 2014 at 08:00:50AM +0200, Stefan Wahren wrote: > Am 28.09.2014 um 12:22 schrieb Mark Brown: > > Use subject lines matching the style for the subsystem. > sorry i'm not sure what's wrong with the subject lines. > Did you expect "[PATCH 1/2] regulator: add binding for mxs regulator"? Yes. > > While this should be using compatibles to identify which regulator is > > being supported note that the binding doesn't document the fact that the > > code makes regulator-name mandatory or what values are required. > Is the following better? > - fsl,mxs-regulator-vddd > - fsl,mxs-regulator-vdda > - fsl,mxs-regulator-vddio Yes.
Attachment:
signature.asc
Description: Digital signature