Re: [PATCH v2] i2c: axxia: Add I2C driver for AXM55xx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/29/2014 03:43 PM, Wolfram Sang wrote:
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Error checking on *res*...?

We should *return* on platform_get_resource() failure..

+	base = devm_ioremap_resource(&pdev->dev, res);
Nope. devm_ioremap_resource does that.

Yes it will [1]. Thanks for the clarification.

[1]:http://lxr.free-electrons.com/source/lib/devres.c#L117

--
Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux