On Wed, Jun 29, 2022 at 03:42:42PM +0200, AngeloGioacchino Del Regno wrote:
> Il 29/06/22 14:13, Allen-KH Cheng ha scritto:
> > Add dsi ndoe for mt8192 SoC.
Typo: s/ndoe/node.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > index 26d01544b4ea..72af328126de 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> > @@ -1334,6 +1334,24 @@
> > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>;
> > };
> > + dsi0: dsi@14010000 {
> > + compatible = "mediatek,mt8183-dsi";
> > + reg = <0 0x14010000 0 0x1000>;
> > + interrupts = <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH 0>;
> > + mediatek,syscon-dsi = <&mmsys 0x140>;
Also drop this syscon-dsi property.
> > + clocks = <&mmsys CLK_MM_DSI0>,
> > + <&mmsys CLK_MM_DSI_DSI0>,
> > + <&mipi_tx0>;
> > + clock-names = "engine", "digital", "hs";
> > + phys = <&mipi_tx0>;
> > + phy-names = "dphy";
It's also missing power-domains.
>
> resets = <&mmsys MT8192_MMSYS_SW0_RST_B_DISP_DSI0>;
>
> ^^^ This is missing, please add it and resend :-)
Also, when this is added you'll need
#include <dt-bindings/reset/mt8192-resets.h>
With those addressed,
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
Thanks,
Nícolas
>
> > + status = "disabled";
> > +
> > + port {
> > + dsi_out: endpoint { };
> > + };
> > + };
> > +
> > ovl_2l2: ovl@14014000 {
> > compatible = "mediatek,mt8192-disp-ovl-2l";
> > reg = <0 0x14014000 0 0x1000>;
>
>
>
