Re: [PATCH 08/11] dt-bindings: display/msm: add mdp-opp-table to dpu-sdm845

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 29 June 2022 12:23:48 GMT+03:00, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>On 28/06/2022 22:23, Dmitry Baryshkov wrote:
>
>>>> +    $ref: /schemas/opp/opp-v2.yaml#
>>>> +
>>>>    ports:
>>>>      $ref: /schemas/graph.yaml#/properties/ports
>>>>      description: |
>>>> @@ -116,11 +120,12 @@ examples:
>>>>                            <0x0aeb0000 0x2008>;
>>>>                      reg-names = "mdp", "vbif";
>>>>  
>>>> -                    clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>>> +                    clocks = <&gcc GCC_DISP_AXI_CLK>,
>>>> +                             <&dispcc DISP_CC_MDSS_AHB_CLK>,
>>>
>>> What does the OPP table have to do with clocks? Adding a clock anywhere 
>>> but the end is an ABI break.
>> 
>> I should split this to a separate patch. And, I must admit, this clock change has already landed. We did not think that it is an ABI break since we have clock-names here.
>
>xxx-names are only a helper and order of items is always strict, thus
>any change in the order is always ABI break.

Ack, we will keep this in mind. However in this case we have already made this change. So the question in his do we cope with it.

-- 
With best wishes
Dmitry




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux