On Wed, Jun 29, 2022 at 11:38:01AM +0200, Krzysztof Kozlowski wrote: > On 28/06/2022 16:55, Stephan Gerhold wrote: > > Document the "qcom,msm8909-tlmm" compatible for the TLMM/pin control > > block in the MSM8909 SoC, together with the allowed GPIOs and functions. > > > > Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxxxxxxx> > > --- > > .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 152 ++++++++++++++++++ > > 1 file changed, 152 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > new file mode 100644 > > index 000000000000..e03530091478 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,msm8909-tlmm.yaml > > @@ -0,0 +1,152 @@ > > [...] > > +patternProperties: > > + '-state$': > > + oneOf: > > + - $ref: "#/$defs/qcom-msm8909-tlmm-state" > > No quotes here and other places, should be needed. I know you copied > from other bindings, but at least let's try new files to be proper. > The quotes are necessary, since # starts a comment in YAML and the property would be effectively empty. :) I tried it anyway but "dt_binding_check" complains as suspected: qcom,msm8909-tlmm.yaml: patternProperties:-state$:oneOf:0:$ref: None is not of type 'string' Thanks, Stephan
