Is it better in mxs_auart_init_gpios(): a) to block DMA by disabling MXS_AUART_RTSCTS (misleading name problem) b) or just warn (depends on DT) if MXS_AUART_RTSCTS is set and CTS or RTS is defined as GPIO line? Then MXS_AUART_RTSCTS could be used instead of CTS_AT_AUART() in the interrupt and mxs_auart_settermios(). What do you think about RTSEN? It is set in mxs_auart_settermios() and mxs_auart_set_mctrl(). [PATCH 1/2] serial: mxs-auart: use mctrl_gpio helpers for handling * RTS_AT_AUART() and CTS_AT_AUART() macro defined * DMA engine disabled if RTS or CTS is GPIO line * CTSEN can't be enabled for hardware flow control block if CTS is defined as GPIO line * RTSEN can be enabled for hardware flow control block even if RTS is defined as GPIO line. RTS pin depends on pinctrl configuration which selects RTS output from hardware flow control block or GPIO line. * mxs_auart_settermios(): RTS_AT_AUART() and CTS_AT_AUART() used * mxs_auart_irq_handle(): CTS_AT_AUART() used * mxs_auart_init_gpios() returns true(success)/false(failure) * dev_err() message fixed in mxs_auart_probe() [PATCH 2/2] serial: mxs-auart: add interrupts for modem control * rebased -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
