On 23/06/2022 18:28, Sebastian Reichel wrote: > Add compatible string for RK3588 gmac, which is similar to the RK3568 > one, but needs another syscon device for clock selection. > > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 6 ++++++ > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 1 + > 2 files changed, 7 insertions(+) Rebase on some new kernel tree, you use old Cc addresses. > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 083623c8d718..c42f5a74a92e 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -25,6 +25,7 @@ select: > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > - rockchip,rk3568-gmac > + - rockchip,rk3588-gmac > - rockchip,rv1108-gmac > required: > - compatible > @@ -50,6 +51,7 @@ properties: > - items: > - enum: > - rockchip,rk3568-gmac > + - rockchip,rk3588-gmac > - const: snps,dwmac-4.20a > > clocks: > @@ -81,6 +83,10 @@ properties: > description: The phandle of the syscon node for the general register file. > $ref: /schemas/types.yaml#/definitions/phandle > > + rockchip,php_grf: What does the "php" mean? No underscores in names, hyphens instead. Best regards, Krzysztof