On Tue, Jun 21, 2022 at 11:42 AM Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
>
> These PMICs all contain a GPIO controller. Now that the binding is
> documented, wire up the controller in the device tree.
>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> ---
>
> (no changes since v1)
>
> arch/arm/boot/dts/axp22x.dtsi | 18 ++++++++++++++++++
> arch/arm/boot/dts/axp809.dtsi | 19 +++++++++++++++++++
> 2 files changed, 37 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp22x.dtsi b/arch/arm/boot/dts/axp22x.dtsi
> index a020c12b2884..5c233c84be92 100644
> --- a/arch/arm/boot/dts/axp22x.dtsi
> +++ b/arch/arm/boot/dts/axp22x.dtsi
> @@ -67,6 +67,24 @@ battery_power_supply: battery-power {
> status = "disabled";
> };
>
> + axp_gpio: gpio {
> + compatible = "x-powers,axp221-gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + /omit-if-no-ref/
> + gpio0_ldo: gpio0-ldo-pin {
> + pins = "GPIO0";
> + function = "ldo";
> + };
> +
> + /omit-if-no-ref/
> + gpio1_ldo: gpio1-ldo-pin {
> + pins = "GPIO1";
> + function = "ldo";
> + };
> + };
> +
We have
reg_ldo_io0: ldo-io0 {
pinctrl-names = "default";
pinctrl-0 = <&gpio0_ldo>;
/* Disable by default to avoid conflicts with GPIO */
...
}
in axp81x.dtsi . Should we add it here and for axp803.dtsi as well?
Otherwise,
Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>
