On Fri, Jun 24, 2022 at 4:16 PM Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx> wrote: > > Hi, > > On Fri, Jun 24, 2022 at 07:37:08PM +0200, Andrew Lunn wrote: > > > The Rockchip hardware supports enabling/disabling delays and > > > configuring a delay value of 0x00-0x7f. For the RK3588 evaluation > > > board the RX delay should be disabled. > > > > So you can just put 0 in DT then. > > My understanding is, that there is a difference between > enabled delay with a delay value of 0 and delay fully > disabled. But I could not find any details aboout this > in the datasheet unfortunately. The driver already sets the delays to 0 in case of the rgmii-id modes. 0 is disabled, even in this patch. The only thing this patch does is change the behavior when the delays are not set. If the rx delays should be 0, they should be defined as 0 in the device tree. There is rgmii-rxid for a reason as well, but if they are setting the rx delay to 0 with rgmii that implies this hardware is fundamentally broken. Very Respectfully, Peter Geis > > -- Sebastian > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-rockchip
