Re: [PATCH v3 11/12] mmc: sunxi: Convert MMC driver to the standard clock phase API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi
Great! Since I didn't see any mistakes from my side it shouldn't be a problem.
Because someone has borrowed my UART2USB(FT232)-cable I unfortunately can't
test the code for now.
If you can verfiy that all the adaptions are working properly on A10/A20 and
all the others you my assume my:
	Acked-by: David Lanzendörfer <david.lanzendoerfer@xxxxxx>

chears and all the best
david

> > > [...]
> > How did you calculate the actual phase values from the original
> > parameters?
>
> Like shown in the clock driver. 0 is always a 180 deg phase shift, and
> any other value is the number of the parent clock cycle to outphase
> the clock of.
> 
> the clock out phase is calculating using:
> 
> phase = 360 * interval / period.
> 
> with period = 1 / (parent_freq / divider)
> and interval = reg / parent_freq
> 
> which makes
> 
> phase = 360 * (reg / parent_freq) * (parent_freq / divider)
> 
> If we simplify by removing the parent_freq, we end up with
> 
> phase = 360 * reg / divider, which makes it rather trivial to
> calculate.
> 
> Maxime

-- 
David Lanzendörfer
OpenSourceSupport GmbH
System engineer and supporter
http://www.o2s.ch/

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux