On Wed 22 Jun 03:47 CDT 2022, Johan Hovold wrote:
> On Tue, Jun 21, 2022 at 09:12:19PM -0700, Bjorn Andersson wrote:
> > Add the CRD (Customer Reference Design?) and the Lenovo Thinkpad X13s to
>
> Qualcomm refers to "Compute Reference Design", for example, in commit
> 427b249504ea ("arm64: dts: qcom: sc7280-crd: Add device tree files for
> CRD").
>
I'll align with that expansion of the abbreviation, thanks.
> > the valid device compatibles found on the sc8280xp platform.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >
> > Changes since v1:
> > - Added the two missing board compatibles
> >
> > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 5c06d1bfc046..6ec7521be19d 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -238,6 +238,8 @@ properties:
> >
> > - items:
> > - enum:
> > + - lenovo,thinkpad-x13s
> > + - qcom,sc8280xp-crd
> > - qcom,sc8280xp-qrd
>
> I believe the "qcom,sc8280xp-qrd" entry was a mistake and should have
> been "-crd" all along? Perhaps you should remove that entry in this
> patch.
It was a mistake on my part adding the QRD when apparently I had a CRD,
but I still believe both exists, so I'd prefer to just keep them around.
Regards,
Bjorn
>
> > - const: qcom,sc8280xp
>
> Looks good otherwise:
>
> Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
>
> Johan
