Hi Geert,
On Thursday 25 September 2014 12:10:59 Geert Uytterhoeven wrote:
> On Thu, Sep 25, 2014 at 11:57 AM, Laurent Pinchart wrote:
> > On Thursday 25 September 2014 09:06:46 Geert Uytterhoeven wrote:
> >> On Wed, Sep 24, 2014 at 10:04 PM, Laurent Pinchart
> >>
> >> <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote:
> >> > +- adi,input-style: The input components arrangement variant (1, 2 or
> >> > 3).
> >>
> >> What's the meaning of the numerical values 1, 2, and 3?
> >>
> >> I found this code in "[PATCH 11/12] drm: Add adv7511 encoder driver":
> >>
> >> + input_style = config->input_style == 1 ? 2
> >> + : (config->input_style == 2 ? 1 : 3);
> >>
> >> which didn't really help much ;-)
> >>
> > :-)
> >
> > The ADV751[13]W? datasheets document all the supported input formats.
> > They're split in categories, each of them having multiple variants called
> > styles. The styles are just numbered 1, 2 and 3 in the tables that
> > describe the formats, and there's a register field used to select a
> > style. For some reason style 1 maps to register value 2, style 2 to
> > register value 1, and style 3 to register value 3. Go figure...
>
> Thanks, that explains it.
>
> Then I suggest to reflect this in the binding:
>
> - adi,input-style: The input components arrangement variant (1, 2 or 3),
> as listed in the datasheet.
>
> and in the code, e.g. by translating the values using a mapping array?
I'll document the property as
- adi,input-style: The input components arrangement variant (1, 2 or 3), as
listed in the input format tables in the datasheet.
and modify the code to use an array as in
/*
* The input style values documented in the datasheet don't match the
* hardware register field values :-(
*/
static const unsigned int input_styles[4] = { 0, 2, 1, 3 };
...
regmap_update_bits(adv7511->regmap, ADV7511_REG_VIDEO_INPUT_CFG1, 0x7e,
(color_depth << 4) |
(input_styles[config->input_style] << 2));
(config->input_style is validated when parsing DT).
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
