On 22/06/2022 15:44, Johan Hovold wrote: > On Wed, Jun 22, 2022 at 02:37:02PM +0200, Konrad Dybcio wrote: >> On 22.06.2022 06:12, Bjorn Andersson wrote: > >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/sa8295p-adp.dts >>> @@ -0,0 +1,427 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2021, The Linux Foundation. All rights reserved. >>> + * Copyright (c) 2022, Linaro Limited >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/gpio/gpio.h> >> Can be moved to SoC dtsi. > > No, the SoC dtsi does not use any defines from that header file. Even if the DTSI used these constants, it is a good practice to include headers in each file using them. The same as we always do for C code. Best regards, Krzysztof
