On Tue, 2022-06-21 at 14:11 +0200, AngeloGioacchino Del Regno wrote: > Il 21/06/22 13:37, Bo-Chen Chen ha scritto: > > MediaTek dpi supports direct connection to pins while dp_intf does > > not > > support. Therefore, add a config "support_direct_pin" to control > > this. > > > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx> > > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 17 +++++++++++++---- > > 1 file changed, 13 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > > b/drivers/gpu/drm/mediatek/mtk_dpi.c > > index 438bf3bc5e4a..ef7f828a4b1e 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > > @@ -129,6 +129,8 @@ struct mtk_dpi_yc_limit { > > * @is_ck_de_pol: Support CK/DE polarity. > > * @swap_input_support: Support input swap function. > > * @color_fmt_trans_support: Enable color format transfer. > > + * @support_direct_pin: Dpi can directly connect pins, and enable > > this config > > + * to do this. > > @support_direct_pin: IP supports direct connection to pins > > or > > @support_direct_pin: IP has direct connection to DP pins > > or > > @support_direct_pin: IP connects directly to DP pins > > pick one, after which: > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@xxxxxxxxxxxxx> > > Hello Angelo, this is not connect to "DP" pin. This setting is for dpi to connect to panel directly and there is no such usecase for dp_intf. Therefore, I will use "@support_direct_pin: IP supports direct connection to pins". Thanks BRs, Bo-Chen