Hi Krzysztof, On Tue, 21 Jun 2022 at 18:40, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 21/06/2022 15:14, Tomer Maimon wrote: > > Add binding for the Arbel BMC NPCM8XX Clock controller. > > > > Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx> > > --- > > .../bindings/clock/nuvoton,npcm845-clk.yaml | 49 +++++++++++++++++++ > > .../dt-bindings/clock/nuvoton,npcm845-clk.h | 49 +++++++++++++++++++ > > 2 files changed, 98 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > create mode 100644 include/dt-bindings/clock/nuvoton,npcm845-clk.h > > > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > new file mode 100644 > > index 000000000000..3d4fddc090ca > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/nuvoton,npcm845-clk.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Nuvoton NPCM8XX Clock Controller Binding > > + > > +maintainers: > > + - Tomer Maimon <tmaimon77@xxxxxxxxx> > > + > > +description: | > > + Nuvoton Arbel BMC NPCM8XX contains an integrated clock controller, which > > + generates and supplies clocks to all modules within the BMC. > > + > > +properties: > > + compatible: > > + enum: > > + - nuvoton,npcm845-clk > > + > > + reg: > > + maxItems: 1 > > + > > + '#clock-cells': > > + const: 1 > > + description: > > + See include/dt-bindings/clock/nuvoton,npcm8xx-clock.h for the full > > + list of NPCM8XX clock IDs. > > + > > +required: > > + - compatible > > + - reg > > + - "#clock-cells" > > You fixed one comment and ignore second. The same was with v3. Sorry, I missed the quotes comment, will be addressed next version. > > This is still no. Implement all the comments you received. I have to > double check your patchsets every time because I cannot trust that you > implemented what I asked for. > > > Best regards, > Krzysztof Best regards, Tomer
