On Tue, Jun 21, 2022 at 12:51:50AM +0300, Dmitry Baryshkov wrote:
> Use parent_data for the last remaining entry (pll4). This clock is
> provided by the lcc device.
>
> Fixes: cb02866f9a74 ("clk: qcom: gcc-ipq806x: convert parent_names to parent_data")
> Cc: Ansuel Smith <ansuelsmth@xxxxxxxxx>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
> drivers/clk/qcom/gcc-ipq806x.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq806x.c b/drivers/clk/qcom/gcc-ipq806x.c
> index 718de17a1e60..6447f3e81b55 100644
> --- a/drivers/clk/qcom/gcc-ipq806x.c
> +++ b/drivers/clk/qcom/gcc-ipq806x.c
> @@ -79,7 +79,9 @@ static struct clk_regmap pll4_vote = {
> .enable_mask = BIT(4),
> .hw.init = &(struct clk_init_data){
> .name = "pll4_vote",
> - .parent_names = (const char *[]){ "pll4" },
> + .parent_data = &(const struct clk_parent_data){
> + .fw_name = "pll4", .name = "pll4",
> + },
> .num_parents = 1,
> .ops = &clk_pll_vote_ops,
> },
> --
> 2.35.1
>
Hi my intention was finding a way to directly reference the hw clk from
the lcc driver instead of using fw_name/name parent data. Wonder if that
would be a better solution... Seems wrong to me to eventually add also
the pll4 clk in the dts to correctly use the fw_name definition (when
that will be fixed in the ipq8064 dtsi)
--
Ansuel
