On 21/06/2022 12:15, Steffen Trumtrar wrote: > The Phytec STM32MP1 based SoMs feature up to 1 GB DDR3LP RAM, up to 1 GB eMMC, Wrong wrapping. https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > up to 16 MB QSPI and up to 128 GB NAND flash. > > As multiple default pinctrls are overwritten, collect them in one place > in stm32mp157c-phycore-stm32mp15-pinctrl.dtsi. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@xxxxxxxxxxxxxx> > --- > Changes since v2: > - /delete-property/dmas > - fix dtbs_checks warnings > - remove problematic+unused nodes > > > arch/arm/boot/dts/Makefile | 3 +- > ...stm32mp157c-phycore-stm32mp15-pinctrl.dtsi | 317 +++++++++ > .../stm32mp157c-phycore-stm32mp15-som.dtsi | 634 ++++++++++++++++++ > 3 files changed, 953 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi > create mode 100644 arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 184899808ee7..de5c3cadb01a 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1213,7 +1213,8 @@ dtb-$(CONFIG_ARCH_STM32) += \ > stm32mp157c-ev1.dtb \ > stm32mp157c-ev1-scmi.dtb \ > stm32mp157c-lxa-mc1.dtb \ > - stm32mp157c-odyssey.dtb > + stm32mp157c-odyssey.dtb \ > + stm32mp157c-phycore-stm32mp1-3.dtb This is a mess... where is the DTS? Please do not send code which does not compile. > dtb-$(CONFIG_MACH_SUN4I) += \ > sun4i-a10-a1000.dtb \ > sun4i-a10-ba10-tvbox.dtb \ > diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi > new file mode 100644 > index 000000000000..b0b590df43b6 > --- /dev/null > +++ b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-pinctrl.dtsi > @@ -0,0 +1,317 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * Copyright (C) Phytec GmbH 2019-2020 - All Rights Reserved > + * Author: Dom VOVARD <dom.vovard@xxxxxxxxx>. > + */ > +#include "stm32mp15-pinctrl.dtsi" > + > +&pinctrl { > + dcmi_pins_a: dcmi-0 { > + pins { > + pinmux = <STM32_PINMUX('H', 8, AF13)>,/* DCMI_HSYNC */ > + <STM32_PINMUX('B', 7, AF13)>,/* DCMI_VSYNC */ > + <STM32_PINMUX('A', 6, AF13)>,/* DCMI_PIXCLK */ > + <STM32_PINMUX('H', 9, AF13)>,/* DCMI_D0 */ > + <STM32_PINMUX('C', 7, AF13)>,/* DCMI_D1 */ > + <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */ > + <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */ > + <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */ > + <STM32_PINMUX('I', 4, AF13)>,/* DCMI_D5 */ > + <STM32_PINMUX('E', 5, AF13)>,/* DCMI_D6 */ > + <STM32_PINMUX('I', 7, AF13)>,/* DCMI_D7 */ > + <STM32_PINMUX('I', 1, AF13)>,/* DCMI_D8 */ > + <STM32_PINMUX('H', 7, AF13)>;/* DCMI_D9 */ > + bias-disable; > + }; > + }; > + > + dcmi_sleep_pins_a: dcmi-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('H', 8, ANALOG)>,/* DCMI_HSYNC */ > + <STM32_PINMUX('B', 7, ANALOG)>,/* DCMI_VSYNC */ > + <STM32_PINMUX('A', 6, ANALOG)>,/* DCMI_PIXCLK */ > + <STM32_PINMUX('H', 9, ANALOG)>,/* DCMI_D0 */ > + <STM32_PINMUX('C', 7, ANALOG)>,/* DCMI_D1 */ > + <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */ > + <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */ > + <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */ > + <STM32_PINMUX('I', 4, ANALOG)>,/* DCMI_D5 */ > + <STM32_PINMUX('E', 5, ANALOG)>,/* DCMI_D6 */ > + <STM32_PINMUX('I', 7, ANALOG)>,/* DCMI_D7 */ > + <STM32_PINMUX('I', 1, ANALOG)>,/* DCMI_D8 */ > + <STM32_PINMUX('H', 7, ANALOG)>;/* DCMI_D9 */ > + }; > + }; > + > + ethernet0_rgmii_pins_a: rgmii-0 { > + pins1 { > + pinmux = <STM32_PINMUX('G', 4, AF11)>, /* ETH_RGMII_GTX_CLK */ > + <STM32_PINMUX('G', 13, AF11)>, /* ETH_RGMII_TXD0 */ > + <STM32_PINMUX('G', 14, AF11)>, /* ETH_RGMII_TXD1 */ > + <STM32_PINMUX('C', 2, AF11)>, /* ETH_RGMII_TXD2 */ > + <STM32_PINMUX('E', 2, AF11)>, /* ETH_RGMII_TXD3 */ > + <STM32_PINMUX('B', 11, AF11)>, /* ETH_RGMII_TX_CTL */ > + <STM32_PINMUX('A', 2, AF11)>, /* ETH_MDIO */ > + <STM32_PINMUX('C', 1, AF11)>; /* ETH_MDC */ > + bias-disable; > + drive-push-pull; > + slew-rate = <2>; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('C', 4, AF11)>, /* ETH_RGMII_RXD0 */ > + <STM32_PINMUX('C', 5, AF11)>, /* ETH_RGMII_RXD1 */ > + <STM32_PINMUX('H', 6, AF11)>, /* ETH_RGMII_RXD2 */ > + <STM32_PINMUX('B', 1, AF11)>, /* ETH_RGMII_RXD3 */ > + <STM32_PINMUX('A', 1, AF11)>, /* ETH_RGMII_RX_CLK */ > + <STM32_PINMUX('A', 7, AF11)>; /* ETH_RGMII_RX_CTL */ > + bias-disable; > + }; > + }; > + > + ethernet0_rgmii_pins_sleep_a: rgmii-sleep-0 { > + pins1 { > + pinmux = <STM32_PINMUX('G', 4, ANALOG)>, /* ETH_RGMII_GTX_CLK */ > + <STM32_PINMUX('G', 13, ANALOG)>, /* ETH_RGMII_TXD0 */ > + <STM32_PINMUX('G', 14, ANALOG)>, /* ETH_RGMII_TXD1 */ > + <STM32_PINMUX('C', 2, ANALOG)>, /* ETH_RGMII_TXD2 */ > + <STM32_PINMUX('E', 2, ANALOG)>, /* ETH_RGMII_TXD3 */ > + <STM32_PINMUX('B', 11, ANALOG)>, /* ETH_RGMII_TX_CTL */ > + <STM32_PINMUX('A', 2, ANALOG)>, /* ETH_MDIO */ > + <STM32_PINMUX('C', 1, ANALOG)>, /* ETH_MDC */ > + <STM32_PINMUX('C', 4, ANALOG)>, /* ETH_RGMII_RXD0 */ > + <STM32_PINMUX('C', 5, ANALOG)>, /* ETH_RGMII_RXD1 */ > + <STM32_PINMUX('H', 6, ANALOG)>, /* ETH_RGMII_RXD2 */ > + <STM32_PINMUX('B', 1, ANALOG)>, /* ETH_RGMII_RXD3 */ > + <STM32_PINMUX('A', 1, ANALOG)>, /* ETH_RGMII_RX_CLK */ > + <STM32_PINMUX('A', 7, ANALOG)>; /* ETH_RGMII_RX_CTL */ > + }; > + }; > + > + i2c1_pins_a: i2c1-0 { > + pins { > + pinmux = <STM32_PINMUX('F', 14, AF5)>, /* I2C1_SCL */ > + <STM32_PINMUX('F', 15, AF5)>; /* I2C1_SDA */ > + bias-disable; > + drive-open-drain; > + slew-rate = <0>; > + }; > + }; > + > + i2c1_pins_sleep_a: i2c1-1 { > + pins { > + pinmux = <STM32_PINMUX('F', 14, ANALOG)>, /* I2C1_SCL */ > + <STM32_PINMUX('F', 15, ANALOG)>; /* I2C1_SDA */ > + }; > + }; > + > + pwm5_pins_a: pwm5-0 { > + pins { > + pinmux = <STM32_PINMUX('I', 0, AF2)>; /* TIM5_CH4 */ > + bias-pull-down; > + drive-push-pull; > + slew-rate = <0>; > + }; > + }; > + > + pwm5_sleep_pins_a: pwm5-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('I', 0, ANALOG)>; /* TIM5_CH4 */ > + }; > + }; > + > + sai2b_pins_a: sai2b-0 { > + pins1 { > + pinmux = <STM32_PINMUX('H', 2, AF10)>, /* SAI2_SCK_B */ > + <STM32_PINMUX('C', 0, AF8)>, /* SAI2_FS_B */ > + <STM32_PINMUX('H', 3, AF10)>; /* SAI2_MCLK_B */ > + slew-rate = <0>; > + drive-push-pull; > + bias-disable; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('F', 11, AF10)>; /* SAI2_SD_B */ > + bias-disable; > + }; > + }; > + > + sdmmc1_b4_pins_a: sdmmc1-b4-0 { > + pins1 { > + pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1_D0 */ > + <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1_D1 */ > + <STM32_PINMUX('E', 6, AF8)>, /* SDMMC1_D2 */ > + <STM32_PINMUX('C', 11, AF12)>, /* SDMMC1_D3 */ > + <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1_CMD */ > + slew-rate = <1>; > + drive-push-pull; > + bias-disable; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1_CK */ > + slew-rate = <2>; > + drive-push-pull; > + bias-disable; > + }; > + }; > + > + sdmmc1_b4_od_pins_a: sdmmc1-b4-od-0 { > + pins1 { > + pinmux = <STM32_PINMUX('C', 8, AF12)>, /* SDMMC1_D0 */ > + <STM32_PINMUX('C', 9, AF12)>, /* SDMMC1_D1 */ > + <STM32_PINMUX('E', 6, AF8)>, /* SDMMC1_D2 */ > + <STM32_PINMUX('C', 11, AF12)>; /* SDMMC1_D3 */ > + slew-rate = <1>; > + drive-push-pull; > + bias-disable; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('C', 12, AF12)>; /* SDMMC1_CK */ > + slew-rate = <2>; > + drive-push-pull; > + bias-disable; > + }; > + pins3 { > + pinmux = <STM32_PINMUX('D', 2, AF12)>; /* SDMMC1_CMD */ > + slew-rate = <1>; > + drive-open-drain; > + bias-disable; > + }; > + }; > + > + sdmmc1_b4_sleep_pins_a: sdmmc1-b4-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('C', 8, ANALOG)>, /* SDMMC1_D0 */ > + <STM32_PINMUX('C', 9, ANALOG)>, /* SDMMC1_D1 */ > + <STM32_PINMUX('E', 6, ANALOG)>, /* SDMMC1_D2 */ > + <STM32_PINMUX('C', 11, ANALOG)>, /* SDMMC1_D3 */ > + <STM32_PINMUX('C', 12, ANALOG)>, /* SDMMC1_CK */ > + <STM32_PINMUX('D', 2, ANALOG)>; /* SDMMC1_CMD */ > + }; > + }; > + > + sdmmc2_d47_pins_a: sdmmc2-d47-0 { > + pins { > + pinmux = <STM32_PINMUX('A', 8, AF9)>, /* SDMMC2_D4 */ > + <STM32_PINMUX('A', 9, AF10)>, /* SDMMC2_D5 */ > + <STM32_PINMUX('C', 6, AF10)>, /* SDMMC2_D6 */ > + <STM32_PINMUX('D', 3, AF9)>; /* SDMMC2_D7 */ > + slew-rate = <1>; > + drive-push-pull; > + bias-pull-up; > + }; > + }; > + > + sdmmc2_d47_sleep_pins_a: sdmmc2-d47-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('A', 8, ANALOG)>, /* SDMMC2_D4 */ > + <STM32_PINMUX('A', 9, ANALOG)>, /* SDMMC2_D5 */ > + <STM32_PINMUX('C', 6, ANALOG)>, /* SDMMC2_D6 */ > + <STM32_PINMUX('D', 3, ANALOG)>; /* SDMMC2_D7 */ > + }; > + }; > + > + usart1_pins_b: usart1-1 { > + pins1 { > + pinmux = <STM32_PINMUX('A', 12, AF7)>; /* USART1_RTS */ > + bias-disable; > + drive-push-pull; > + slew-rate = <0>; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('A', 11, AF7)>; /* USART1_CTS_NSS */ > + bias-disable; > + }; > + }; > + > + usart1_idle_pins_b: usart1-idle-1 { > + pins1 { > + pinmux = <STM32_PINMUX('A', 12, ANALOG)>, /* USART1_RTS */ > + <STM32_PINMUX('A', 11, AF7)>; /* USART1_CTS_NSS */ > + }; > + }; > + > + usart1_sleep_pins_b: usart1-sleep-1 { > + pins { > + pinmux = <STM32_PINMUX('A', 12, ANALOG)>, /* USART1_RTS */ > + <STM32_PINMUX('A', 11, ANALOG)>; /* USART1_CTS_NSS */ > + }; > + }; > + > + usart3_idle_pins_a: usart3-idle-0 { > + pins1 { > + pinmux = <STM32_PINMUX('B', 10, ANALOG)>; /* USART3_TX */ > + }; > + pins2 { > + pinmux = <STM32_PINMUX('B', 12, AF8)>; /* USART3_RX */ > + bias-disable; > + }; > + }; > + > + usart3_sleep_pins_a: usart3-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('B', 10, ANALOG)>, /* USART3_TX */ > + <STM32_PINMUX('B', 12, ANALOG)>; /* USART3_RX */ > + }; > + }; > +}; > + > +&pinctrl_z { > + spi1_sleep_pins_a: spi1-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('Z', 0, ANALOG)>, /* SPI1_SCK */ > + <STM32_PINMUX('Z', 1, ANALOG)>, /* SPI1_MISO */ > + <STM32_PINMUX('Z', 2, ANALOG)>; /* SPI1_MOSI */ > + }; > + }; > + > + usart1_idle_pins_a: usart1-idle-0 { > + pins1 { > + pinmux = <STM32_PINMUX('Z', 7, ANALOG)>; /* USART1_TX */ > + }; > + pins2 { > + pinmux = <STM32_PINMUX('Z', 6, AF7)>; /* USART1_RX */ > + bias-disable; > + }; > + }; > + > + usart1_sleep_pins_a: usart1-sleep-0 { > + pins { > + pinmux = <STM32_PINMUX('Z', 7, ANALOG)>, /* USART1_TX */ > + <STM32_PINMUX('Z', 6, ANALOG)>; /* USART1_RX */ > + }; > + }; > + > + usart1_pins_a: usart1-0 { > + pins1 { > + pinmux = <STM32_PINMUX('Z', 7, AF7)>; /* USART1_TX */ > + bias-disable; > + drive-push-pull; > + slew-rate = <0>; > + }; > + pins2 { > + pinmux = <STM32_PINMUX('Z', 6, AF7)>; /* USART1_RX */ > + bias-disable; > + }; > + }; > +}; > + > +&sai2a_pins_b { > + pins { > + pinmux = <STM32_PINMUX('I', 6, AF10)>; /* SAI2_SD_A */ > + bias-disable; > + }; > +}; > + > +&sai2a_sleep_pins_b { > + pins { > + pinmux = <STM32_PINMUX('I', 6, ANALOG)>; /* SAI2_SD_A */ > + }; > +}; > + > +&sai2b_sleep_pins_a { > + pins { > + pinmux = <STM32_PINMUX('F', 11, ANALOG)>, /* SAI2_SD_B */ > + <STM32_PINMUX('H', 2, ANALOG)>, /* SAI2_SCK_B */ > + <STM32_PINMUX('C', 0, ANALOG)>, /* SAI2_FS_B */ > + <STM32_PINMUX('H', 3, ANALOG)>; /* SAI2_MCLK_B */ > + }; > +}; > diff --git a/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi > new file mode 100644 > index 000000000000..6e401a8b1f20 > --- /dev/null > +++ b/arch/arm/boot/dts/stm32mp157c-phycore-stm32mp15-som.dtsi > @@ -0,0 +1,634 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * Copyright (C) Phytec GmbH 2019-2020 - All Rights Reserved > + * Author: Dom VOVARD <dom.vovard@xxxxxxxxx>. > + */ > + > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/interrupt-controller/irq.h> > +#include <dt-bindings/leds/leds-pca9532.h> > +#include <dt-bindings/mfd/st,stpmic1.h> > +#include <dt-bindings/net/ti-dp83867.h> > +#include "stm32mp157c-phycore-stm32mp15-pinctrl.dtsi" > + > +/ { > + aliases { > + ethernet0 = ðernet0; > + mmc0 = &sdmmc1; > + mmc1 = &sdmmc2; > + mmc2 = &sdmmc3; > + rtc0 = &i2c4_rtc; > + rtc1 = &rtc; > + serial0 = &uart4; > + serial1 = &usart3; > + serial2 = &usart1; Usually UART aliases belong to board, not to SoC DTSI. MMC probably as well as it might be enabled or might not (lack of SD card socket). However since this is SoM, maybe these are fixed and board using the SoM cannot disable eMMC? > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + status = "okay"; > + > + home { key-home Schema will require it. > + label = "Home"; > + gpios = <&gpioa 13 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_HOME>; > + }; > + > + enter { key-enter > + label = "Enter"; > + gpios = <&gpioa 14 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_ENTER>; > + }; > + }; > + > + reserved-memory { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + retram: retram@38000000 { > + compatible = "shared-dma-pool"; > + reg = <0x38000000 0x10000>; > + no-map; > + }; > + > + mcuram: mcuram@30000000 { > + compatible = "shared-dma-pool"; > + reg = <0x30000000 0x40000>; > + no-map; > + }; > + > + mcuram2: mcuram2@10000000 { > + compatible = "shared-dma-pool"; > + reg = <0x10000000 0x40000>; > + no-map; > + }; > + > + vdev0vring0: vdev0vring0@10040000 { > + compatible = "shared-dma-pool"; > + reg = <0x10040000 0x1000>; > + no-map; > + }; > + > + vdev0vring1: vdev0vring1@10041000 { > + compatible = "shared-dma-pool"; > + reg = <0x10041000 0x1000>; > + no-map; > + }; > + > + vdev0buffer: vdev0buffer@10042000 { > + compatible = "shared-dma-pool"; > + reg = <0x10042000 0x4000>; > + no-map; > + }; > + > + gpu_reserved: gpu@f8000000 { > + reg = <0xf8000000 0x8000000>; > + no-map; > + }; > + }; > + > + sound { > + compatible = "audio-graph-card"; > + label = "STM32MP1-PHYCORE"; > + routing = > + "Playback", "MCLK", /* Set a route between "MCLK" and "playback" widgets */ > + "Capture", "MCLK"; > + dais = <&sai2b_port>, > + <&sai2a_port>; > + status = "okay"; > + }; > + > + vin: vin { Node name: vin-regulator or regulator-vin > + compatible = "regulator-fixed"; > + regulator-name = "vin"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-always-on; > + }; > +}; > + > +ðernet0 { > + status = "okay"; > + pinctrl-0 = <ðernet0_rgmii_pins_a>; > + pinctrl-1 = <ðernet0_rgmii_pins_sleep_a>; > + pinctrl-names = "default", "sleep"; > + phy-mode = "rgmii-id"; > + max-speed = <1000>; > + phy-handle = <&phy0>; > + st,eth-clk-sel; > + clock-names = "stmmaceth", > + "mac-clk-tx", > + "mac-clk-rx", > + "eth-ck", > + "syscfg-clk", > + "ethstp"; > + clocks = <&rcc ETHMAC>, > + <&rcc ETHTX>, > + <&rcc ETHRX>, > + <&rcc ETHCK_K>, > + <&rcc SYSCFG>, > + <&rcc ETHSTP>; > + > + mdio0 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + > + phy0: ethernet-phy@1 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <1>; > + interrupt-parent = <&gpiog>; > + interrupts = <12 IRQ_TYPE_EDGE_FALLING>; > + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; > + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>; > + ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>; > + ti,min-output-impedance; > + enet-phy-lane-no-swap; > + ti,clk-output-sel = <DP83867_CLK_O_SEL_OFF>; > + }; > + }; > +}; > + > +&gpu { > + contiguous-area = <&gpu_reserved>; > +}; > + > +&i2c1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&i2c1_pins_a>; > + pinctrl-1 = <&i2c1_pins_sleep_a>; > + i2c-scl-rising-time-ns = <100>; > + i2c-scl-falling-time-ns = <7>; > + status = "okay"; > + > + tlv320@18 { Generic node name. > + compatible = "ti,tlv320aic3007"; > + #sound-dai-cells = <0>; > + reg = <0x18>; Put reg directly after compatible. > + status = "okay"; No need, it's by default. > + > + ai3x-micbias-vg = <2>; > + > + /* gpio-reset = <&gpio5 8 GPIO_ACTIVE_LOW>; */ > + AVDD-supply = <&v3v3>; > + IOVDD-supply = <&v3v3>; > + DRVDD-supply = <&v3v3>; > + DVDD-supply = <&v1v8_audio>; > + > + clocks = <&sai2b>; > + clock-names = "MCLK"; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + tlv320_tx_endpoint: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&sai2b_endpoint>; > + frame-master; > + bitclock-master; > + }; > + > + tlv320_rx_endpoint: endpoint@1 { > + reg = <1>; > + remote-endpoint = <&sai2a_endpoint>; > + frame-master; > + bitclock-master; > + }; > + }; > + }; > + > + stmpe811@44 { Generic node names > + compatible = "st,stmpe811"; > + reg = <0x44>; > + interrupts = <3 2>; 2 looks like IRQ flag, so use it. > + interrupt-parent = <&gpioi>; > + vio-supply = <&v3v3>; > + vcc-supply = <&v3v3>; > + status = "disabled"; Why disabled? > + > + stmpe_touchscreen { > + compatible = "st,stmpe-ts"; > + st,sample-time = <4>; > + st,mod-12b = <1>; > + st,ref-sel = <0>; > + st,adc-freq = <1>; > + st,ave-ctrl = <1>; > + st,touch-det-delay = <2>; > + st,settling = <2>; > + st,fraction-z = <7>; > + st,i-drive = <1>; > + }; > + }; > + > + pca9533@62 { Generic node name > + compatible = "nxp,pca9533"; > + reg = <0x62>; > + status = "okay"; No need for this. > + > + red-power { Wrong names. Follow the schema, so recommended is led-0. > + label = "pca:red:power"; Label is being deprecated (or even was). Instead use function and color. > + type = <PCA9532_TYPE_LED>; > + }; > + > + green-power {> + label = "pca:green:power"; Ditto - node name/label > + type = <PCA9532_TYPE_LED>; > + }; > + > + blue-power { Ditto - node name, missing function and color. > + type = <PCA9532_TYPE_LED>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > +}; > + > +&i2c4 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&i2c4_pins_a>; > + pinctrl-1 = <&i2c4_sleep_pins_a>; > + i2c-scl-rising-time-ns = <185>; > + i2c-scl-falling-time-ns = <20>; > + status = "okay"; > + > + stpmic@33 { Generic node name. > + compatible = "st,stpmic1"; > + reg = <0x33>; > + interrupts-extended = <&gpioa 0 IRQ_TYPE_EDGE_FALLING>; > + interrupt-controller; > + #interrupt-cells = <2>; > + status = "okay"; Really? Again? > + > + regulators { > + compatible = "st,stpmic1-regulators"; > + buck1-supply = <&vin>; > + buck2-supply = <&vin>; > + buck3-supply = <&vin>; > + buck4-supply = <&vin>; > + ldo1-supply = <&v3v3>; > + ldo2-supply = <&v3v3>; > + ldo3-supply = <&vdd_ddr>; > + ldo4-supply = <&vin>; > + ldo5-supply = <&v3v3>; > + ldo6-supply = <&v3v3>; > + vref_ddr-supply = <&vin>; > + boost-supply = <&vin>; > + pwr_sw1-supply = <&bst_out>; > + pwr_sw2-supply = <&bst_out>; > + > + vddcore: buck1 { > + regulator-name = "vddcore"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1350000>; > + regulator-always-on; > + regulator-initial-mode = <0>; > + regulator-over-current-protection; > + }; > + > + vdd_ddr: buck2 { > + regulator-name = "vdd_ddr"; > + regulator-min-microvolt = <1350000>; > + regulator-max-microvolt = <1350000>; > + regulator-always-on; > + regulator-initial-mode = <0>; > + regulator-over-current-protection; > + }; > + > + vdd: buck3 { > + regulator-name = "vdd"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + st,mask-reset; > + regulator-initial-mode = <0>; > + regulator-over-current-protection; > + }; > + > + v3v3: buck4 { > + regulator-name = "v3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + regulator-over-current-protection; > + regulator-initial-mode = <0>; > + }; > + > + v1v8_audio: ldo1 { > + regulator-name = "v1v8_audio"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-always-on; > + interrupts = <IT_CURLIM_LDO1 0>; > + > + }; > + > + vdd_eth_2v5: ldo2 { > + regulator-name = "dd_eth_2v5"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <2500000>; > + regulator-always-on; > + interrupts = <IT_CURLIM_LDO2 0>; > + > + }; > + > + vtt_ddr: ldo3 { > + regulator-name = "vtt_ddr"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <750000>; > + regulator-always-on; > + regulator-over-current-protection; > + }; > + > + vdd_usb: ldo4 { > + regulator-name = "vdd_usb"; > + interrupts = <IT_CURLIM_LDO4 0>; > + }; > + > + vdda: ldo5 { > + regulator-name = "vdda"; > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <2900000>; > + interrupts = <IT_CURLIM_LDO5 0>; > + regulator-boot-on; > + }; > + > + vdd_eth_1v0: ldo6 { > + regulator-name = "vdd_eth_1v0"; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1000000>; > + regulator-always-on; > + interrupts = <IT_CURLIM_LDO6 0>; > + > + }; > + > + vref_ddr: vref_ddr { No underscores in node names, unless something requires it. > + regulator-name = "vref_ddr"; > + regulator-always-on; > + regulator-over-current-protection; > + }; > + > + bst_out: boost { > + regulator-name = "bst_out"; > + interrupts = <IT_OCP_BOOST 0>; > + }; > + > + vbus_otg: pwr_sw1 { > + regulator-name = "vbus_otg"; > + interrupts = <IT_OCP_OTG 0>; > + regulator-active-discharge = <1>; > + }; > + > + vbus_sw: pwr_sw2 { > + regulator-name = "vbus_sw"; > + interrupts = <IT_OCP_SWOUT 0>; > + regulator-active-discharge = <1>; > + }; > + }; > + > + onkey { > + compatible = "st,stpmic1-onkey"; > + interrupts = <IT_PONKEY_F 0>, > + <IT_PONKEY_R 0>; > + interrupt-names = "onkey-falling", > + "onkey-rising"; > + power-off-time-sec = <10>; > + status = "okay"; > + }; > + > + watchdog { > + compatible = "st,stpmic1-wdt"; > + status = "disabled"; > + }; > + }; > + > + i2c4_eeprom: eeprom@50 { > + compatible = "microchip,24c32", > + "atmel,24c32"; > + reg = <0x50>; > + status = "disabled"; > + }; > + > + i2c4_rtc: rtc@52 { > + compatible = "microcrystal,rv3028"; > + reg = <0x52>; > + status = "disabled"; > + }; > +}; > + > +&ipcc { > + status = "okay"; > +}; > + > +&iwdg2 { > + timeout-sec = <32>; > + status = "okay"; > +}; > + > +&m_can2 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&m_can2_pins_a>; > + pinctrl-1 = <&m_can2_sleep_pins_a>; > + status = "okay"; > +}; > + > +&m4_rproc { > + memory-region = <&retram>, <&mcuram>, <&mcuram2>, <&vdev0vring0>, > + <&vdev0vring1>, <&vdev0buffer>; > + mboxes = <&ipcc 0>, <&ipcc 1>, <&ipcc 2>, <&ipcc 3>; > + mbox-names = "vq0", "vq1", "shutdown", "detach"; > + interrupt-parent = <&exti>; > + interrupts = <68 1>; > + status = "okay"; > +}; > + > +&pwr_regulators { > + vdd-supply = <&vdd>; > + vdd_3v3_usbfs-supply = <&vdd_usb>; > +}; > + > +&qspi { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&qspi_clk_pins_a &qspi_bk1_pins_a>; > + pinctrl-1 = <&qspi_clk_sleep_pins_a &qspi_bk1_sleep_pins_a>; > + reg = <0x58003000 0x1000>, > + <0x70000000 0x4000000>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + > + flash0: flash@0 { > + compatible = "winbond,w25q128", "jedec,spi-nor", "spi-flash"; Wrong compatible. You did not run checkpatch, which is a requirement. > + reg = <0>; > + spi-rx-bus-width = <4>; > + spi-max-frequency = <50000000>; > + m25p,fast-read; > + #address-cells = <1>; > + #size-cells = <1>; > + }; > +}; > + > +&rng1 { > + status = "okay"; > +}; > + > +&rtc { > + status = "okay"; > +}; > + > +&sai2 { > + clocks = <&rcc SAI2>, <&rcc PLL3_Q>, <&rcc PLL3_R>; > + clock-names = "pclk", "x8k", "x11k"; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sai2a_pins_b>, <&sai2b_pins_a>; > + pinctrl-1 = <&sai2a_sleep_pins_b>, <&sai2b_sleep_pins_a>; > + status = "okay"; > + > + sai2a: audio-controller@4400b004 { > + compatible = "st,stm32-sai-sub-a"; > + dma-names = "rx"; > + st,sync = <&sai2b 2>; > + status = "okay"; Come on... > + clocks = <&rcc SAI2_K>, > + <&sai2b>; > + clock-names = "sai_ck", "MCLK"; > + > + sai2a_port: port { > + sai2a_endpoint: endpoint { > + remote-endpoint = <&tlv320_rx_endpoint>; > + format = "i2s"; > + mclk-fs = <256>; > + dai-tdm-slot-num = <2>; > + dai-tdm-slot-width = <16>; > + }; > + }; > + }; > + > + sai2b: audio-controller@4400b024 { > + compatible = "st,stm32-sai-sub-b"; Undocumented compatible. Not accepted. > + #clock-cells = <0>; > + dma-names = "tx"; > + clocks = <&rcc SAI2_K>; > + clock-names = "sai_ck"; > + status = "okay"; Drop it... > + > + sai2b_port: port { > + sai2b_endpoint: endpoint { > + remote-endpoint = <&tlv320_tx_endpoint>; > + format = "i2s"; > + mclk-fs = <256>; > + dai-tdm-slot-num = <2>; > + dai-tdm-slot-width = <16>; > + }; > + }; > + }; > +}; > + > +&sdmmc1 { > + pinctrl-names = "default", "opendrain", "sleep"; > + pinctrl-0 = <&sdmmc1_b4_pins_a>; > + pinctrl-1 = <&sdmmc1_b4_od_pins_a>; > + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; > + cd-gpios = <&gpiof 3 GPIO_ACTIVE_LOW>; > + disable-wp; > + st,neg-edge; > + bus-width = <4>; > + vmmc-supply = <&v3v3>; > + status = "okay"; > +}; > + > +&sdmmc2 { > + pinctrl-names = "default", "opendrain", "sleep"; > + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_a>; > + pinctrl-1 = <&sdmmc2_b4_od_pins_a &sdmmc2_d47_pins_a>; > + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_a>; > + non-removable; > + no-sd; > + no-sdio; > + st,neg-edge; > + bus-width = <8>; > + vmmc-supply = <&v3v3>; > + vqmmc-supply = <&v3v3>; > + mmc-ddr-3_3v; > + status = "disabled"; > +}; > + > +&spi1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&spi1_pins_a>; > + pinctrl-1 = <&spi1_sleep_pins_a>; > + cs-gpios = <&gpioz 3 0>; > + status = "okay"; > + > + spi@0 { > + compatible = "spidev"; Whooo, you did not test the bindings, did you? You should see fat warnings from all over. spidev is not accepted. > + spi-max-frequency = <10000000>; > + reg = <0>; > + }; > +}; Best regards, Krzysztof
