On 20.06.2022 23:12, Marijn Suijten wrote: > 2700000 is not a multiple of pmic4_pldo's step size of 8000 (with base > voltage 1664000), resulting in pm8998-rpmh-regulators not probing. Just > as we did with MSM8998's Sony Yoshino Poplar [1], round the voltages > down to err on the cautious side and leave a comment in place to > document this discrepancy wrt downstream sources. > > [1]: https://lore.kernel.org/linux-arm-msm/20220507153627.1478268-1-marijn.suijten@xxxxxxxxxxxxxx/ > > Fixes: 30a7f99befc6 ("arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)") > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> Konrad > .../arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > index 36ff1178b705..3839850cf7dd 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama-akatsuki.dts > @@ -22,8 +22,9 @@ &vreg_l14a_1p8 { > }; > > &vreg_l22a_2p8 { > - regulator-min-microvolt = <2700000>; > - regulator-max-microvolt = <2700000>; > + /* Note: Round-down from 2700000 to be a multiple of PLDO step-size 8000 */ > + regulator-min-microvolt = <2696000>; > + regulator-max-microvolt = <2696000>; > }; > > &vreg_l28a_2p8 {
