> > >> + /* Sanity check, is this all zeroes? */ > >> + if (memchr_inv(data, 0x00, 16) == NULL) { > > > > if (!memchr_inv(...)) > > > >> + if (FIELD_GET(GENMASK(5, 0), data[16]) == 0) > >> + dev_warn(yas5xx->dev, "calibration is blank!\n"); > >> + } > > No problem to change for YAS537. > > At YAS530/532, there is a similar line that should be changed > accordingly. However, there is a patch by Linus that was already added > to "fixes-togreg" branch in iio.git quite a while ago [5]. The patch is > not included in torvalds/linux v5.19-rc1 or -rc2 and neither in iio.git > testing branch. So I'm unsure what I should base the patchset on if I > want to change that line. I will probably choose linux-next, as the > patch is included there and in Kconfig also patch "iio: magnetometer: > ak8974: Drop dependency on OF" is included (which on the other hand > isn't included in "fixes-togreg" branch in iio.git). > > [5] > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=bb52d3691db8cf24cea049235223f3599778f264 Busy couple of weeks for me and that fix got caught up in the merge window timing before that. I should get a pull request out shortly. Jonathan