On 17/06/2022 00:08, Francesco Dolcini wrote: > This series allows to specify the imx thermal drivers trip point from the device tree, > without this change the threshold are hard-coded and this might not be correct given the > thermal design of the final system. > > This change is backward compatible with the existing device tree, and even > with this change in by default the thresholds are the same as before. > > Toradex board are also updated to use a system-specific thresholds. > > Discussion on the current design is here: > https://lore.kernel.org/all/4ba1d7d2-3e8c-ba60-37fd-9598f415c076@xxxxxxxxxx/ > > One side note, after this change the dtbs checker starts complaining with this message > > ``` > linux/arch/arm/boot/dts/imx6dl-alti6p.dtb: tempmon: '#thermal-sensor-cells' does not match any of the regexes: '^(automotive|commercial|extended-commercial|industrial)-thermal$', 'pinctrl-[0-9]+' > From schema: linux/Documentation/devicetree/bindings/thermal/imx-thermal.yaml > ``` > > to my understanding this is just a side effect, If it starts complaining, it does not look like a side effect but error needing to be fixed/addressed. > '#thermal-sensor-cells' is not changed in > any way by this series. I can fix that, I wonder if I should remove the property from the > imx dtsi files or add it to the binding yaml definition, not sure about it. > Anybody can advise? Depends. Is the device a thermal-sensor provider? Best regards, Krzysztof
