Hi "Peng, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on shawnguo/for-next linus/master v5.19-rc2 next-20220616] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/Add-interconnect-for-i-MX8MP-blk-ctrl/20220616-153932 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arc-randconfig-r043-20220616 (https://download.01.org/0day-ci/archive/20220616/202206161809.ZDbwd4YD-lkp@xxxxxxxxx/config) compiler: arc-elf-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/60034edb256677d3671a2409c83c8a0a2c11d101 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Peng-Fan-OSS/Add-interconnect-for-i-MX8MP-blk-ctrl/20220616-153932 git checkout 60034edb256677d3671a2409c83c8a0a2c11d101 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/soc/imx/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): drivers/soc/imx/imx8mp-blk-ctrl.c: In function 'imx8mp_blk_ctrl_probe': >> drivers/soc/imx/imx8mp-blk-ctrl.c:539:23: error: implicit declaration of function 'devm_of_icc_bulk_get'; did you mean 'of_icc_bulk_get'? [-Werror=implicit-function-declaration] 539 | ret = devm_of_icc_bulk_get(dev, data->num_paths, domain->paths); | ^~~~~~~~~~~~~~~~~~~~ | of_icc_bulk_get cc1: some warnings being treated as errors vim +539 drivers/soc/imx/imx8mp-blk-ctrl.c 466 467 static int imx8mp_blk_ctrl_probe(struct platform_device *pdev) 468 { 469 const struct imx8mp_blk_ctrl_data *bc_data; 470 struct device *dev = &pdev->dev; 471 struct imx8mp_blk_ctrl *bc; 472 void __iomem *base; 473 int num_domains, i, ret; 474 475 struct regmap_config regmap_config = { 476 .reg_bits = 32, 477 .val_bits = 32, 478 .reg_stride = 4, 479 }; 480 481 bc = devm_kzalloc(dev, sizeof(*bc), GFP_KERNEL); 482 if (!bc) 483 return -ENOMEM; 484 485 bc->dev = dev; 486 487 bc_data = of_device_get_match_data(dev); 488 num_domains = bc_data->num_domains; 489 490 base = devm_platform_ioremap_resource(pdev, 0); 491 if (IS_ERR(base)) 492 return PTR_ERR(base); 493 494 regmap_config.max_register = bc_data->max_reg; 495 bc->regmap = devm_regmap_init_mmio(dev, base, ®map_config); 496 if (IS_ERR(bc->regmap)) 497 return dev_err_probe(dev, PTR_ERR(bc->regmap), 498 "failed to init regmap\n"); 499 500 bc->domains = devm_kcalloc(dev, num_domains, 501 sizeof(struct imx8mp_blk_ctrl_domain), 502 GFP_KERNEL); 503 if (!bc->domains) 504 return -ENOMEM; 505 506 bc->onecell_data.num_domains = num_domains; 507 bc->onecell_data.xlate = imx8m_blk_ctrl_xlate; 508 bc->onecell_data.domains = 509 devm_kcalloc(dev, num_domains, 510 sizeof(struct generic_pm_domain *), GFP_KERNEL); 511 if (!bc->onecell_data.domains) 512 return -ENOMEM; 513 514 bc->bus_power_dev = genpd_dev_pm_attach_by_name(dev, "bus"); 515 if (IS_ERR(bc->bus_power_dev)) 516 return dev_err_probe(dev, PTR_ERR(bc->bus_power_dev), 517 "failed to attach bus power domain\n"); 518 519 bc->power_off = bc_data->power_off; 520 bc->power_on = bc_data->power_on; 521 522 for (i = 0; i < num_domains; i++) { 523 const struct imx8mp_blk_ctrl_domain_data *data = &bc_data->domains[i]; 524 struct imx8mp_blk_ctrl_domain *domain = &bc->domains[i]; 525 int j; 526 527 domain->data = data; 528 529 for (j = 0; j < data->num_clks; j++) 530 domain->clks[j].id = data->clk_names[j]; 531 532 for (j = 0; j < data->num_paths; j++) { 533 domain->paths[j].name = data->path_names[j]; 534 /* Fake value for now, just let ICC could configure NoC mode/priority */ 535 domain->paths[j].avg_bw = 1; 536 domain->paths[j].peak_bw = 1; 537 } 538 > 539 ret = devm_of_icc_bulk_get(dev, data->num_paths, domain->paths); 540 if (ret) { 541 dev_err_probe(dev, ret, "failed to get noc entries\n"); 542 goto cleanup_pds; 543 } 544 545 546 ret = devm_clk_bulk_get(dev, data->num_clks, domain->clks); 547 if (ret) { 548 dev_err_probe(dev, ret, "failed to get clock\n"); 549 goto cleanup_pds; 550 } 551 552 domain->power_dev = 553 dev_pm_domain_attach_by_name(dev, data->gpc_name); 554 if (IS_ERR(domain->power_dev)) { 555 dev_err_probe(dev, PTR_ERR(domain->power_dev), 556 "failed to attach power domain %s\n", 557 data->gpc_name); 558 ret = PTR_ERR(domain->power_dev); 559 goto cleanup_pds; 560 } 561 dev_set_name(domain->power_dev, "%s", data->name); 562 563 domain->genpd.name = data->name; 564 domain->genpd.power_on = imx8mp_blk_ctrl_power_on; 565 domain->genpd.power_off = imx8mp_blk_ctrl_power_off; 566 domain->bc = bc; 567 domain->id = i; 568 569 ret = pm_genpd_init(&domain->genpd, NULL, true); 570 if (ret) { 571 dev_err_probe(dev, ret, "failed to init power domain\n"); 572 dev_pm_domain_detach(domain->power_dev, true); 573 goto cleanup_pds; 574 } 575 576 /* 577 * We use runtime PM to trigger power on/off of the upstream GPC 578 * domain, as a strict hierarchical parent/child power domain 579 * setup doesn't allow us to meet the sequencing requirements. 580 * This means we have nested locking of genpd locks, without the 581 * nesting being visible at the genpd level, so we need a 582 * separate lock class to make lockdep aware of the fact that 583 * this are separate domain locks that can be nested without a 584 * self-deadlock. 585 */ 586 lockdep_set_class(&domain->genpd.mlock, 587 &blk_ctrl_genpd_lock_class); 588 589 bc->onecell_data.domains[i] = &domain->genpd; 590 } 591 592 ret = of_genpd_add_provider_onecell(dev->of_node, &bc->onecell_data); 593 if (ret) { 594 dev_err_probe(dev, ret, "failed to add power domain provider\n"); 595 goto cleanup_pds; 596 } 597 598 bc->power_nb.notifier_call = bc_data->power_notifier_fn; 599 ret = dev_pm_genpd_add_notifier(bc->bus_power_dev, &bc->power_nb); 600 if (ret) { 601 dev_err_probe(dev, ret, "failed to add power notifier\n"); 602 goto cleanup_provider; 603 } 604 605 dev_set_drvdata(dev, bc); 606 607 return 0; 608 609 cleanup_provider: 610 of_genpd_del_provider(dev->of_node); 611 cleanup_pds: 612 for (i--; i >= 0; i--) { 613 pm_genpd_remove(&bc->domains[i].genpd); 614 dev_pm_domain_detach(bc->domains[i].power_dev, true); 615 } 616 617 dev_pm_domain_detach(bc->bus_power_dev, true); 618 619 return ret; 620 } 621 -- 0-DAY CI Kernel Test Service https://01.org/lkp
