Quoting Doug Anderson (2022-06-14 15:41:25) > On Tue, Jun 14, 2022 at 12:51 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + const: google,cros-ec-spi > > + required: > > + - compatible > > + - boot0-gpios > > I've never personally used "select" before and I'm not sure where it's > documented. Without knowing anything, it seems weird to me that in > this file we're matching against a compatible that's not > google,cros-ec-fp. Randomly grabbing some other example that's similar > (panel-lvds.yaml) looks more like what I would have expected. AKA in > this file: > > select: > properties: > compatible: > contains: > const: google,cros-ec-fp > required: > - compatible > > ...and then in the other file: > > select: > properties: > compatible: > contains: > const: google,cros-ec-spi > not: > properties: > compatible: > contains: > const: google,cros-ec-fp > required: > - compatible > > > Of course, if one of the dt maintainers gives different advice then > listen to them. ;-) > I followed a pwm example, see renesas,tpu-pwm.yaml, but I suspect this works just as well. I don't really care either way so I'll defer to DT maintainers here.
